*** Original post on bio 2076 at 2013-07-28 13:53:00 UTC *** This is a regression.

*** Original post on bio 2076 as attmnt 2656 at 2013-07-30 21:08:00 UTC *** Sorry for this (embarrassing) regression.

*** Original post on bio 2076 as attmnt 2658 at 2013-07-30 21:41:00 UTC *** This sets the whole list item's opacity rather than individual items'. This noticeably improves scrolling performance on Mac, but also makes the highlight slightly faded as well. I'm not sure about whether this is good or bad, so I'm attaching it as it is now - please let me know your opinion.

Comment on attachment 8354425 [details] [diff] [review] Patch *** Original change on bio 2076 attmnt 2656 at 2013-07-30 21:41:33 UTC was without comment, so any subsequent comment numbers will be shifted ***

Comment on attachment 8354427 [details] [diff] [review] Patch 2 *** Original change on bio 2076 attmnt 2658 at 2013-08-02 08:50:37 UTC *** This indeed fixes the opacity problem with contacts but the reduced highlighting for selected contacts looks odd. It's seeming to say that the hovered item is not fully functional (which is not true as some protocols (AIM/ICQ (OSCAR), Facebook?) allow to send messages to offline contacts).

*** Original post on bio 2076 at 2013-08-08 14:55:39 UTC *** See http://log.bezut.info/instantbird/130730#m373 and http://log.bezut.info/instantbird/130802#m116 "if you really have a scrolling speed issue when setting the opacity on a child of the item, do you think it would be interesting to try setting the opacity on the item itself when it's not selected, and on the first child if the item is selected/highlighted?"

Comment on attachment 8354427 [details] [diff] [review] Patch 2 *** Original change on bio 2076 attmnt 2658 at 2013-08-16 11:07:09 UTC *** After comment 3 and comment 4, I'm not sure which kind of feedback is expected from me, so removing the review request for now.

*** Original post on bio 2076 as attmnt 2919 at 2013-10-01 10:56:00 UTC *** This fixes the bug. However, it has the side effect that possible chat items, which are fully opaque, appear right after offline contacts (semi-transparent) - this looks a bit odd to me, and I thought I'd get some feedback before trying possible "fix"es.

Comment on attachment 8354427 [details] [diff] [review] Patch 2 *** Original change on bio 2076 attmnt 2658 at 2013-10-01 10:56:17 UTC was without comment, so any subsequent comment numbers will be shifted ***

Comment on attachment 8354689 [details] [diff] [review] Patch 3 *** Original change on bio 2076 attmnt 2919 at 2013-10-01 10:57:11 UTC was without comment, so any subsequent comment numbers will be shifted ***

*** Original post on bio 2076 at 2013-10-01 16:54:57 UTC *** (In reply to comment #6) > This fixes the bug. However, it has the side effect that possible chat items, > which are fully opaque, appear right after offline contacts (semi-transparent) > - this looks a bit odd to me, and I thought I'd get some feedback before trying > possible "fix"es. The opacity sounds correct, as those possible channels are online. Maybe this will look less strange once the styling of MUC items is improved, so they look more readily distinguishable from contacts.

Comment on attachment 8354689 [details] [diff] [review] Patch 3 *** Original change on bio 2076 attmnt 2919 at 2013-10-03 22:33:39 UTC *** Alright, nhnt11 would really like to have this in nightlies sooner than later, so I'm willing to take half the blame if it turns out to not be perfect! r=me.

*** Original post on bio 2076 at 2013-10-03 22:48:20 UTC *** http://hg.instantbird.org/instantbird/rev/0f76fc65b9c1