Closed
Bug 955650
Opened 11 years ago
Closed 11 years ago
Error from log sweeping with a fresh profile
Categories
(Instantbird Graveyard :: Conversation, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
1.5
People
(Reporter: nhnt11, Assigned: benediktp)
References
Details
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
aleth
:
review+
|
Details | Diff | Splinter Review |
*** Original post on bio 2205 at 2013-10-06 10:50:00 UTC ***
As reported by aleth. I don't have the exact error to paste here but it's because the log dir doesn't exist.
Assignee | ||
Comment 1•11 years ago
|
||
*** Original post on bio 2205 as attmnt 2994 at 2013-10-29 21:18:00 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8354775 -
Flags: review?(aleth)
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → benediktp
Status: NEW → ASSIGNED
Comment 2•11 years ago
|
||
Comment on attachment 8354775 [details] [diff] [review]
Patch
*** Original change on bio 2205 attmnt 2994 at 2013-10-30 09:58:56 UTC ***
>+ if(aError instanceof OS.File.Error && !aError.becauseNoSuchFile)
>+ Cu.reportError("Error while sweeping logs folder: " + logsPath + "\n" + aError);
Nit: space after if
Looks good otherwise!
Attachment #8354775 -
Flags: review?(aleth) → review-
Assignee | ||
Comment 3•11 years ago
|
||
*** Original post on bio 2205 as attmnt 3011 at 2013-11-03 23:35:00 UTC ***
Oops.
Attachment #8354792 -
Flags: review?(aleth)
Assignee | ||
Comment 4•11 years ago
|
||
Comment on attachment 8354775 [details] [diff] [review]
Patch
*** Original change on bio 2205 attmnt 2994 at 2013-11-03 23:35:57 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8354775 -
Attachment is obsolete: true
Comment 5•11 years ago
|
||
Comment on attachment 8354792 [details] [diff] [review]
Updated Patch
*** Original change on bio 2205 attmnt 3011 at 2013-11-04 10:01:58 UTC ***
Thanks!
Attachment #8354792 -
Flags: review?(aleth) → review+
Updated•11 years ago
|
Whiteboard: [checkin-needed]
Comment 6•11 years ago
|
||
*** Original post on bio 2205 at 2013-11-06 16:51:42 UTC ***
Thanks Mic!
http://hg.instantbird.org/instantbird/rev/199c16554b22
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [checkin-needed]
Target Milestone: --- → 1.5
You need to log in
before you can comment on or make changes to this bug.
Description
•