Closed Bug 95567 Opened 24 years ago Closed 23 years ago

javascript strict warnings in enter_bug.cgi

Categories

(Bugzilla :: Creating/Changing Bugs, defect, P3)

Product:
Bugzilla
Component:
Creating/Changing Bugs
Version:
2.13
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Bugzilla 2.16

People

(Reporter: bugzilla, Assigned: myk)

References

Details

(Whiteboard: enter_bug)

Attachments

(1 file, 1 obsolete file)

Patch v.2
(deleted), patch
kiko
: review+
kiko
: review+
Details | Diff | Splinter Review
just go to: http://bugzilla.mozilla.org/enter_bug.cgi?product=Webtools and press Commit and you get: Warning: function onclick does not always return a value Source Code: if (this.form.short_desc.value =='') { alert('Please enter a summary sentence for this bug.'); return false; }
Andreas, this sounds familiar, did we fix this and b.m.o just hasn't picked it up, or is this something new?
I couldn't find this bug somewhere else, so I guess it's a new one. Maybe you were thinking of bug 58436 ?
-> Bugzilla product, Creating Bugs component, reassigning.
Assignee: justdave → myk
Component: Bugzilla → Creating/Changing Bugs
Product: Webtools → Bugzilla
Version: Bugzilla 2.13 → 2.13
Whiteboard: enter_bug
Severity: normal → minor
Priority: -- → P3
Target Milestone: --- → Future
Attached patch Patch to fix warning... (obsolete) (deleted) — — Splinter Review
Depends on: 103953
Keywords: patch, review
*** Bug 118576 has been marked as a duplicate of this bug. ***
Changed milestone to 2.18...should get fixed in 2.16 with templatization of enter_bug.cgi (bug 103953) anyway.
Target Milestone: Future → Bugzilla 2.18
Fixed by the 103953 checkin. No JS warnings now that I can see. Gerv
Status: NEW → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
I spoke too soon. I didn't have JS strict warnings turned on. Sorry :-( Gerv
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Attached patch Patch v.2 (deleted) — — Splinter Review
Updated for use after enter_bug.cgi templatisation bug fix.
Attachment #51832 - Attachment is obsolete: true
Comment on attachment 67785 [details] [diff] [review] Patch v.2 ready for checkin
Attachment #67785 - Flags: review+
and thank god for linebreaks
Checked in. Gerv
Status: REOPENED → RESOLVED
Closed: 23 years ago → 23 years ago
Resolution: --- → FIXED
fixing incorrect milestones on fixed bugs.
Target Milestone: Bugzilla 2.18 → Bugzilla 2.16
QA Contact: matty_is_a_geek → default-qa
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: