Closed
Bug 955945
Opened 11 years ago
Closed 11 years ago
Implement age verification screens for FxA Signup
Categories
(Firefox OS Graveyard :: FxA, defect)
Tracking
(feature-b2g:2.0)
RESOLVED
FIXED
feature-b2g | 2.0 |
People
(Reporter: spenrose, Assigned: ferjm)
References
Details
(Whiteboard: [ucid:FxA48, 1.4:p1, ft:FirefoxAccounts])
Attachments
(2 files)
Per UX specs, when a user enters the signin/signup flow and is sent down the signUP branch (because the FxA server believes their email to represent a new account), they should be sent through Age Verification flow UNLESS the signin/signup flow was triggered via FTU.
Comment 1•11 years ago
|
||
bug 949609 is Bengali, I suspect you wanted to block another bug?
No longer blocks: 949609
Reporter | ||
Comment 2•11 years ago
|
||
(In reply to Axel Hecht [:Pike] from comment #1)
> bug 949609 is Bengali, I suspect you wanted to block another bug?
Yes, I transopsed a pair of digits ... apologies for the noise.
Blocks: 949069
Comment 3•11 years ago
|
||
Sam, I imagine this should actually be filed under a bug for the system app? Settings really just launches the signup flow by opening the system app.
Flags: needinfo?(spenrose)
Reporter | ||
Comment 4•11 years ago
|
||
Jared: sure. I confess the Product/Component rules remain opaque to me. Referring to "Settings" in the description b/c that's how Product/UX experience it, of course.
Flags: needinfo?(spenrose)
Comment 5•11 years ago
|
||
removing from blocker list. COPPA is not committed for 1.4
Comment 6•11 years ago
|
||
whoops, the spreadsheet is a lie. reblocking
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → ferjmoreno
Assignee | ||
Comment 7•11 years ago
|
||
Assignee | ||
Comment 8•11 years ago
|
||
Comment on attachment 8382385 [details] [diff] [review]
WIP
I still need to add some tests for the new screen but I can use some feedback in the meantime.
Attachment #8382385 -
Flags: feedback?(borja.bugzilla)
Assignee | ||
Comment 9•11 years ago
|
||
The PR contains tests now
Comment 10•11 years ago
|
||
Comment on attachment 8382385 [details] [diff] [review]
WIP
Tests coverage is great! This code is working as expected. Some comments to fix before the final review to this code. Let me know when ready! Gracias! :)
Attachment #8382385 -
Flags: feedback?(borja.bugzilla) → feedback+
Assignee | ||
Comment 11•11 years ago
|
||
Assignee | ||
Comment 12•11 years ago
|
||
Comment on attachment 8382385 [details] [diff] [review]
WIP
Thanks Borja! I've just updated the PR.
Attachment #8382385 -
Attachment is patch: true
Attachment #8382385 -
Attachment mime type: text/x-github-pull-request → text/plain
Attachment #8382385 -
Flags: review?(alive)
Comment 13•11 years ago
|
||
Comment on attachment 8382385 [details] [diff] [review]
WIP
Please make any new file jshint friendly! Thanks.
Attachment #8382385 -
Flags: review?(alive)
Assignee | ||
Comment 14•11 years ago
|
||
Comment on attachment 8382385 [details] [diff] [review]
WIP
Thanks Alive. I've just update the PR.
Attachment #8382385 -
Flags: review?(alive)
Updated•11 years ago
|
Attachment #8382385 -
Flags: review?(alive) → review+
Assignee | ||
Comment 15•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•11 years ago
|
Flags: in-moztrap+
Assignee | ||
Updated•11 years ago
|
Component: Identity → FxA
Product: Core → Firefox OS
Updated•11 years ago
|
feature-b2g: --- → 2.0
You need to log in
before you can comment on or make changes to this bug.
Description
•