Closed
Bug 95613
Opened 23 years ago
Closed 18 years ago
Attachment in Eudora-J mail is not imported correctly.
Categories
(MailNews Core :: Internationalization, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: ji, Assigned: smontagu)
References
Details
(Keywords: fixed1.8.1.1, intl)
Attachments
(3 files, 2 obsolete files)
(deleted),
application/octet-stream
|
Details | |
(deleted),
image/jpeg
|
Details | |
(deleted),
patch
|
sugar.waffle
:
review+
mscott
:
superreview+
mscott
:
approval-thunderbird2+
|
Details | Diff | Splinter Review |
This is seperated from bug 64119.
When importing mails from Eudora4.3-J to mozilla, the attachments in a mail
can't be imported correctly. The attachment is just shown as a path in the mail
body.
Steps to reproduce:
1.Have a Eudora-J mailbox contain a mail with attachments.
2.Launch Mozilla Mail.
3.Select Tasks | Import Utility to import Eudora mails to Mozilla.
4.After the import is finished, select the mail that contains attachments.
Select Shift-JIS encoding to correct the view if necessary. you'll see in the
mail body the attachment is shown as a Ja string following by a path to the
attachment file location.
A testing Eudora-J mailbox will be attached.
The Eudora mailbox attached above contains two Ja mails. The first one is
attached with a HTML file with filename in Japanese. The second one is attached
with a txt file with Shift-JIS contents but the attachment filename is in
English.
Keywords: intl
Nominating for nsbeta1 since it causes data loss.
Keywords: nsbeta1
Comment 5•23 years ago
|
||
marking nsbeta1- per mail triage.
Assignee | ||
Comment 7•22 years ago
|
||
Gregg, can you help us understand how this bug should be handled? It's mail related.
thanks,
dassi
Comment 8•22 years ago
|
||
Not sure how important this ranks at this point...need to have triage to discuss.
Comment 11•22 years ago
|
||
Is there still anything happening on this bug? I believe many users would love
to migrate away from eudora 5.2.
It goes for all platforms, by the way.
Comment 12•21 years ago
|
||
Isn't this standard behavior for Eudora? Do you want Mozilla change attachment
storage from 'Eudora-Style' to 'Mozilla-Style' on import?
The Eudora products I've seen (all in English) store attachments as separate
files in the file system, and just have a link to them in the body of the e-mail.
In other words, the attachments are not part of Eudora and not in the Eudora
mailbox files; they're separate files that Eudora merely points to.
I think it would be a separate RFE for Mozilla to import attachments from
'Eudora-Style' to 'Mozilla-Style'.
Comment 13•21 years ago
|
||
for the same problem in French, with a proposed patch, see bug 242948.
Updated•20 years ago
|
Product: MailNews → Core
Comment 14•20 years ago
|
||
Same bug 242948 in french was recently fixed.
The same solution should apply to the japanese version.
Having looked at the mailbox joined I think we should add the japanese
attachment line to the eudoraAttachLines:
static char *eudoraAttachLines[] = {
"Attachment Converted:",
"Attachment converted:",
"Pièce jointe convertie :",
"\225\234\214\263\202\263\202\352\202\275\223\131\225\164\203\164\203\100\203\103\203\213\201\106"
};
static PRInt32 eudoraAttachLen[] = {
21,
21,
24,
24,
0
};
Can someone try and test this solution with japanese eudora ?
Comment 15•18 years ago
|
||
The patch was made referring to comment#14.
I have neither the development environment nor Eudora-J of Windows.
Someone, please make test build so that the person who has Eudora-J may test.
Comment 16•18 years ago
|
||
Comment on attachment 242100 [details] [diff] [review]
Proposal patch
SR needed from ____?
Attachment #242100 -
Flags: review?(smontagu)
Updated•18 years ago
|
Assignee: cavin → smontagu
QA Contact: marina → mailnews.i18n
Assignee | ||
Comment 17•18 years ago
|
||
Comment on attachment 242100 [details] [diff] [review]
Proposal patch
>+ "\225\234\214\263\202\263\202\352\202\275\223\131\225\164\203\164\203\100\203\103\203\213\201\106"
> };
I would prefer this to be in hex escapes rather than decimal, and there should be a comment saying what Japanese string this is, and in what encoding.
Please re-request review after the patch has been tested.
Attachment #242100 -
Flags: review?(smontagu)
Attachment #242100 -
Attachment is obsolete: true
Comment 18•18 years ago
|
||
Update comment#17
Please review after the test ends.
(I cannot test by occasion of comment#15. )
Assignee | ||
Comment 19•18 years ago
|
||
Comment on attachment 246778 [details] [diff] [review]
Proposal patch
>- "Pièce jointe convertie :"
>+ "Pièce jointe convertie :,
This line should be
+ "Pièce jointe convertie :",
With that change, r=smontagu. I tested the patch with the Eudora mailbox in attachment 46071 [details] and it seems to work. There are issues when the filename of the attachment contains Japanese characters, but that can be a follow-up bug.
Attachment #246778 -
Flags: review+
Assignee | ||
Comment 20•18 years ago
|
||
(In reply to comment #16)
> SR needed from ____?
One of the mailnews superreviewers listed in http://www.mozilla.org/hacking/reviewers.html
Attachment #246778 -
Attachment is obsolete: true
Comment 21•18 years ago
|
||
>This line should be
>+ "Pièce jointe convertie :",
This was corrected.
Attachment #247410 -
Flags: review+
Attachment #247410 -
Flags: superreview?(mscott)
Updated•18 years ago
|
Attachment #247410 -
Flags: superreview?(mscott) → superreview+
Comment 22•18 years ago
|
||
Thank you SR, Scott-san.
Simon-san,
Is the check-in possible?
Assignee | ||
Comment 23•18 years ago
|
||
Sure. The tree is closed right now, but I'll do it tomorrow morning.
Assignee | ||
Comment 24•18 years ago
|
||
Checked in. Thanks for the patch.
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Comment 25•18 years ago
|
||
Comment on attachment 247410 [details] [diff] [review]
Update patch
I don't think there's a reason not to take this for thunderbird 2 if Simon doesn't mind landing it on the branch.
Attachment #247410 -
Flags: approval-thunderbird2+
Assignee | ||
Updated•18 years ago
|
Keywords: fixed1.8.1.1
Updated•16 years ago
|
Product: Core → MailNews Core
You need to log in
before you can comment on or make changes to this bug.
Description
•