Closed
Bug 956579
Opened 11 years ago
Closed 11 years ago
Port Bug 955121 - Show participant tooltip when hovering nick in conversation
Categories
(Thunderbird :: Instant Messaging, defect)
Thunderbird
Instant Messaging
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 29.0
People
(Reporter: Paenglab, Assigned: Paenglab)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
aleth
:
review+
|
Details | Diff | Splinter Review |
This bug is to port bug 955121 from IB to TB. It enables the buddyTooltip on conversation nicks.
|
Assignee | |
Comment 1•11 years ago
|
||
I'll port bug 954653 in other bug.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8355890 -
Flags: review?(florian)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 8355890 [details] [diff] [review]
patch
aleth, can you have a look at this please?
I'm confused by what we've done with the FillInHTMLTooltip method of convbrowser.xml. I'm confused that it doesn't exist anymore in Instantbird's chat/ folder, but is still here in comm-central's chat/ folder, even though we merged chat/ recently.
Attachment #8355890 -
Flags: review?(aleth)
|
||
Comment 3•11 years ago
|
||
(In reply to Florian Quèze [:florian] [:flo] from comment #2)
> I'm confused by what we've done with the FillInHTMLTooltip method of
> convbrowser.xml. I'm confused that it doesn't exist anymore in Instantbird's
> chat/ folder, but is still here in comm-central's chat/ folder, even though
> we merged chat/ recently.
The last merge (bug 920801) only covers IB bugs landed before 25/09/13. The bug being ported here landed in November.
|
|
||
Comment 4•11 years ago
|
||
Comment on attachment 8355890 [details] [diff] [review]
patch
I have not tested this patch myself, but it looks good. Thanks, and sorry for the late review!
Attachment #8355890 -
Flags: review?(florian)
Attachment #8355890 -
Flags: review?(aleth)
Attachment #8355890 -
Flags: review+
|
|
Assignee | |
Updated•11 years ago
|
Keywords: checkin-needed
|
|
||
Comment 5•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 29.0
As you are no longer using html namespace in imbuddytooltip.xml, then the xmlns:html could probably be removed:
http://mxr.mozilla.org/comm-central/source/mail/components/im/content/imbuddytooltip.xml#12
Flags: needinfo?(richard.marti)
You need to log in
before you can comment on or make changes to this bug.
Description
•