Closed Bug 956801 Opened 11 years ago Closed 10 years ago

HTTP cache v2: save some locking in CacheEntry::BackgroundOp

Categories

(Core :: Networking: Cache, defect)

defect
Not set
trivial

Tracking

()

RESOLVED FIXED
mozilla33

People

(Reporter: mayhemer, Assigned: mayhemer)

References

(Blocks 1 open bug)

Details

Attachments

(2 files, 1 obsolete file)

Attached patch v1 (obsolete) (deleted) — Splinter Review
(ripped off patch for bug 942835 for merge conflicts)
Attached patch v1 [merged] (deleted) — Splinter Review
It actually just converts unlock/lock/unlock/lock when performing CALLBACKS op to just unlock/lock.
Attachment #8356189 - Attachment is obsolete: true
Attachment #8439298 - Flags: review?(michal.novotny)
Attached patch v1 -w (deleted) — Splinter Review
whitespace ignored one for easier review
Attachment #8439298 - Flags: review?(michal.novotny) → review+
sorry had to back this out in https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=8c81fc70045c since it seems that one of this 3 csets cause failing xpcshell tests on android 2.2 Armv6 like this https://tbpl.mozilla.org/php/getParsedLog.php?id=42255066&tree=Mozilla-Inbound
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: