Chris McAfee Reporter
	Description • 25 years ago

Linux.
Edit foo.html, try to save over original file,
file does not get saved.

	Akkana Peck
	Comment 1 • 25 years ago

Simon said he was rewriting the save code ...

	Simon Fraser [no longer active] Assignee
	Comment 2 • 25 years ago

Sujay, can you test this on all 3 platforms? Thanks.

	sujay
	Comment 3 • 25 years ago

sorry late in getting back to this bug..

Win, Linux, all work for me using recent builds (8/27). But Mac
doesn't work..It still brings in the original file.

I simply created foo.html and then re-edited it changing the
content. Then I re-opened foo.html and saw the changes...

let me know if you needed me to test something different.

	buster
	Comment 4 • 25 years ago

seems like a simple Mac cleanup task.  M13.

	Chris McAfee Reporter
	Comment 5 • 25 years ago

Wait, on Mac you still lose (don't save) your data?
If so, this seems like a huge problem to me, who cares
if it's an easy cleanup task.

	Akkana Peck
	Comment 6 • 25 years ago

On Linux, after Opening a file in the editor and making some changes, clicking
Save or selecting it from the menu brings up a Save As dialog, instead of trying
to save to the original file name.  Then if I navigate through the file
selection dialog back to the original file name and double-click the filename, I
get a dialog that says "Saving file failed!" and indeed, it didn't write the
changes to the file.

There are two bugs here: (1) it should remember the original filename and not
make me re-select it again each time, and (2) it can't save over an existing
file.  Both issues are dogfood, so I'm adding a dependency to the editor dogfood
bug and setting platform to all (since it sounds like it has problems on both
Linux and Mac).

	leger
	Comment 7 • 25 years ago

Putting on [PDT]+ radar.

	Simon Fraser [no longer active] Assignee
	Comment 8 • 25 years ago

This is a file picker issue, not a composer issue. On Mac (and probably windows,
though I don't have a build to check on), the native UI puts up the dialog that
gets the user to confirm that they want to save over an existing file. That UI
needs to be implemenented on linux.

The actual file replacement does not happen until later, and that's covered in
bug 17102.

	Simon Fraser [no longer active] Assignee
	Comment 9 • 25 years ago

Ignore that last comment; it was meant for bug 17102

	Simon Fraser [no longer active] Assignee
	Comment 10 • 25 years ago

Akkana: your first issue above (it should remember which file you opened) is
covered by bug 7929. This bug is that it can't save over an existing file.

I just checked this, and it worked OK on Mac, so I wonder if the only remaining
problem here is the file picker 'replace' UI (bug 17102)? I'll check windows.

	Simon Fraser [no longer active] Assignee
	Comment 11 • 25 years ago

Yeah, this works on windows too, and the replace UI is there too. Moving OS to
linux, marking dep on the linux Replace UI Bug 17102. When that's done, this
might just work.

	Akkana Peck
	Comment 12 • 25 years ago

I'm confused as to why it doesn't just save, if the Save As dialog is saying to
save over the existing file and there is no confirmation dialog.  I understand
that the lack of the confirmation dialog is a bug, but that doesn't explain why
we get an error message when we actually try to save.

	Simon Fraser [no longer active] Assignee
	Comment 13 • 25 years ago

For the replace to work, nsIFileWidget::PutFile() must return
nsFileDlgResults_Replace. My guess is that it is not doing this on linux.

	rubydoo123
	Comment 14 • 25 years ago

this one has not been investigated but, simon knows the problem and has a fix in
mind. He may or may not require assistance from dougt

	Simon Fraser [no longer active] Assignee
	Comment 15 • 25 years ago

Actually the fix will be in linux file widget code; pavlov has the bug that this
depends on

	Simon Fraser [no longer active] Assignee
	Comment 16 • 25 years ago

Since this is entirely dependent on 17102, and no work remains here, closing
this. Note: to verify this, you will have to wait until 17102 is fixed.

	Chris McAfee Reporter
	Comment 17 • 25 years ago

This bug is not fixed, reopening.
Please leave this open so people don't file dups.
Mark it MLater or a dup, but not fixed.

	Simon Fraser [no longer active] Assignee
	Comment 18 • 25 years ago

*** This bug has been marked as a duplicate of 17102 ***

	sujay
	Comment 19 • 25 years ago

verified in 11/17 build.