Closed Bug 957220 Opened 11 years ago Closed 11 years ago

Enable code to build from m-c's config/rules.mk copies

Categories

(MailNews Core :: Build Config, defect)

Product:
MailNews Core
Component:
Build Config
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 29.0

People

(Reporter: jcranmer, Assigned: jcranmer)

References

Details

Attachments

(4 files)

Part 1: Move png2ico out of config/config.mk
(deleted), patch
standard8
: review+
Details | Diff | Splinter Review
Part 2: Stop using LOBJS
(deleted), patch
standard8
: review+
Details | Diff | Splinter Review
Part 3: Shell metacharacter quoting issues
(deleted), patch
standard8
: review+
Details | Diff | Splinter Review
Part 4: Get Windows's make installer working
(deleted), patch
standard8
: review+
Details | Diff | Splinter Review
Coincidentally, all of the changes are specific either to Windows code or pymake code.
It's used in only one place, so might as well not bother trying to port all the logic to m-c for cc-rework. Fortunately, the png part of it is small, so there is no need to muck about with virtualenv \o/
Attachment #8356673 - Flags: review?(mbanner)
Attached patch Part 2: Stop using LOBJS (deleted) — — Splinter Review
This was originally part of my MAPI testing patch, but since that fails on try but not locally for non-obvious reasons, I've pulled the ccrework-blocking portion out of it.
Attachment #8356680 - Flags: review?(mbanner)
Apparently mozilla-central is using pymake builtins to do preprocessing, but comm-central is using shell calls, and pymake screams if you don't quote {.
Attachment #8356681 - Flags: review?(mbanner)
And with this, Alder is now green for Windows.
Attachment #8357194 - Flags: review?(mbanner)
(In reply to Joshua Cranmer [:jcranmer] from comment #1) > Created attachment 8356673 [details] [diff] [review] > Part 1: Move png2ico out of config/config.mk > > It's used in only one place, so might as well not bother trying to port all > the logic to m-c for cc-rework. Fortunately, the png part of it is small, so > there is no need to muck about with virtualenv \o/ There is also a reference to png2ico in http://mxr.mozilla.org/comm-central/source/build/check-sync-exceptions#4
Comment on attachment 8356673 [details] [diff] [review] Part 1: Move png2ico out of config/config.mk r=Standard8 if you update the check-sync-dirs instance as well.
Attachment #8356673 - Flags: review?(mbanner) → review+
Attachment #8356680 - Flags: review?(mbanner) → review+
Attachment #8356681 - Flags: review?(mbanner) → review+
Attachment #8357194 - Flags: review?(mbanner) → review+
Blocks: 1067567
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: