Closed
Bug 957892
Opened 11 years ago
Closed 11 years ago
Support gonk-kk build in gecko
Categories
(Firefox OS Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
1.3 C2/1.4 S2(17jan)
People
(Reporter: seinlin, Assigned: seinlin)
References
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
mwu
:
review+
|
Details | Diff | Splinter Review |
Support gonk-kk build in gecko.
|
Assignee | |
Comment 1•11 years ago
|
||
Now only NFC module is enabled for gonk-kk. For BT, Camera and others need to be enabled when related bug got fixed.
|
|
Assignee | |
Comment 2•11 years ago
|
||
try server result: https://tbpl.mozilla.org/?tree=Try&rev=50a271b7974b
|
||
Comment 3•11 years ago
|
||
Comment on attachment 8357520 [details] [diff] [review]
bug-957892.patch
Review of attachment 8357520 [details] [diff] [review]:
-----------------------------------------------------------------
::: configure.in
@@ +246,5 @@
> MOZ_OMX_DECODER=1
> AC_SUBST(MOZ_OMX_DECODER)
> ;;
> + 19)
> + GONK_INCLUDES="-I$gonkdir/frameworks/native/include -I$gonkdir/frameworks/av/include -I$gonkdir/frameworks/av/include/media -I$gonkdir/frameworks/av/include/camera -I$gonkdir/frameworks/native/include/media/openmax -I$gonkdir/frameworks/av/media/libstagefright/include"
Can you cut this include list down to just -I$gonkdir/frameworks/native/include ? This big global include list was a bit of a hack and we should try to minimize it when updating. I checked locally and it seems to work.
|
|
Assignee | |
Comment 4•11 years ago
|
||
Hi, Michael, I try it does work. New patch is updated.
Attachment #8357520 -
Attachment is obsolete: true
Attachment #8357520 -
Flags: review?(mwu)
Attachment #8357616 -
Flags: review?(mwu)
|
|
||
Comment 5•11 years ago
|
||
Comment on attachment 8357616 [details] [diff] [review]
bug-9957892-fix.patch
Let's check this in when everything else is landed.
Attachment #8357616 -
Flags: review?(mwu) → review+
|
|
||
Comment 7•11 years ago
|
||
|
||
Comment 8•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.3 C2/1.4 S2(17jan)
You need to log in
before you can comment on or make changes to this bug.
Description
•