:Gijs (he/him) Reporter
	Description • 11 years ago

As in screenshot

This is a bit weird, especially because it seems like the UI could just fit in two columns already... I guess there are other locales that might be more verbose, but most of this UI seems like checkbox labels that could just wrap.

And in any case, even if things do need to wrap, the double scrollbar is really weird.

	Brian Grinstead [:bgrins] Assignee
	Comment 1 • 11 years ago

It's harder to view on OSX with disappearing scrollbars, but it seems like this is also happening in that environment as all.  The scroll behavior is jumpy, and you can occasionally see two scrollbars when you get to the bottom and start scrolling back up.

	:Gijs (he/him) Reporter
	Comment 2 • 11 years ago

(In reply to Brian Grinstead [:bgrins] from comment #1)
> It's harder to view on OSX with disappearing scrollbars, but it seems like
> this is also happening in that environment as all.  The scroll behavior is
> jumpy, and you can occasionally see two scrollbars when you get to the
> bottom and start scrolling back up.

(Note that there's actually a system pref to make those persist, and that'll presumably make it easier to see on OS X as well - marking All/All because of this)

	Brian Grinstead [:bgrins] Assignee
	Comment 3 • 11 years ago

I was able to test and repro on OSX using System Preferences -> General -> Show Scroll Bars -> Always.  Can you have a look with the patch applied and make sure it is working in your setup?

	:Gijs (he/him) Reporter
	Comment 4 • 11 years ago

Comment on attachment 8365987 [details] [diff] [review]
double-scrollbar.patch

Yup, that works!

	Brian Grinstead [:bgrins] Assignee
	Comment 5 • 11 years ago

Comment on attachment 8365987 [details] [diff] [review]
double-scrollbar.patch

Review of attachment 8365987 [details] [diff] [review]:
-----------------------------------------------------------------

Optimizer, I believe that you did a lot of the options panel work originally, so just checking that there isn't some case to be aware of where the multiple overflow declarations are needed.  I've also lowered the min-width on the vertical-pane, as it seems to jump to two columns a bit early.

	Girish Sharma [:Optimizer]
	Comment 6 • 11 years ago

I really don't know why, but this is the super-accurate-proper fix.

I also fixed a similar bug that will be reported in future about two horizontal scrollbars . (Yes, I can see the future)

PS: Sorry for stealing the bug Brain, but here you go as reviewer :)

	Girish Sharma [:Optimizer]
	Comment 7 • 11 years ago

err. Brian, not Brain.

	Girish Sharma [:Optimizer]
	Comment 8 • 11 years ago

Comment on attachment 8365987 [details] [diff] [review]
double-scrollbar.patch

Yes, this works. min-* from my patch are not required :)

	Brian Grinstead [:bgrins] Assignee
	Comment 9 • 11 years ago

Comment on attachment 8365987 [details] [diff] [review]
double-scrollbar.patch

This is a quick CSS fix for the options panel that prevents multiple scrollbars at smaller resolutions.

	Brian Grinstead [:bgrins] Assignee
	Comment 10 • 11 years ago

https://hg.mozilla.org/integration/fx-team/rev/182c78677c24
https://tbpl.mozilla.org/?tree=Fx-Team&rev=182c78677c24

	Ryan VanderMeulen [:RyanVM]
	Comment 11 • 11 years ago

https://hg.mozilla.org/mozilla-central/rev/182c78677c24