Closed Bug 958166 Opened 11 years ago Closed 11 years ago

"browser is not defined" error in SessionStore.js when saving a session with tab groups

Categories

(Firefox for Metro Graveyard :: Components, defect, P2)

Product:
Firefox for Metro Graveyard
Component:
Components
Version:
28 Branch
Platform:
All
Windows 8.1
Type:
defect

Tracking

(firefox28 verified, firefox29 verified)

Status:
VERIFIED FIXED
Milestone:
Firefox 29
Tracking Flags:
Tracking Status
firefox28 --- verified
firefox29 --- verified

People

(Reporter: mbrubeck, Assigned: mbrubeck)

References

Details

(Whiteboard: [beta28] [defect] p=1)

Attachments

(1 file)

session
(deleted), patch
emtwo
: review+
lsblakk
: approval-mozilla-aurora+
Details | Diff | Splinter Review
Attached patch session (deleted) — — Splinter Review
Sorry, I missed this in review of bug 956368. The call to _saveTabData(this._tabsFromOtherGroups,...) throws this error because it's expecting a "live" tab rather than tab data from the sessionstore.
Attachment #8357896 - Flags: review?(msamuel)
Priority: -- → P2
QA Contact: jbecerra
Comment on attachment 8357896 [details] [diff] [review] session Review of attachment 8357896 [details] [diff] [review]: ----------------------------------------------------------------- Looks good, Thanks!
Attachment #8357896 - Flags: review?(msamuel) → review+
https://hg.mozilla.org/integration/fx-team/rev/1ef653f9d67b
status-firefox28: --- → affected
status-firefox29: --- → fixed
Whiteboard: [beta28] p=1 → [beta28] p=1 [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/1ef653f9d67b
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [beta28] p=1 [fixed-in-fx-team] → [beta28] p=1
Target Milestone: --- → Firefox 29
Comment on attachment 8357896 [details] [diff] [review] session [Approval Request Comment] Bug caused by (feature/regressing bug #): bug 956368 User impact if declined: Metro session is not saved after switching from a desktop window with multiple tab groups. Testing completed (on m-c, etc.): On m-c since 01-10. Risk to taking this patch (and alternatives if risky): Low-risk, Metro-only. String or IDL/UUID changes made by this patch: None.
Attachment #8357896 - Flags: approval-mozilla-aurora?
Whiteboard: [beta28] p=1 → [beta28] [defect] p=1
Note to anyone doing Aurora uplift: This patch depends on the patch from bug
Whiteboard: [beta28] [defect] p=1 → [beta28] [defect] p=1 [uplift bug 956368 first]
(In reply to Matt Brubeck (:mbrubeck) from comment #5) > Note to anyone doing Aurora uplift: This patch depends on the patch from bug 956368.
Attachment #8357896 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
https://hg.mozilla.org/releases/mozilla-aurora/rev/37f7074626f6
status-firefox28: affected → fixed
Whiteboard: [beta28] [defect] p=1 [uplift bug 956368 first] → [beta28] [defect] p=1
Does this have in-testsuite coverage?
Flags: needinfo?(mbrubeck)
Flags: in-testsuite?
(In reply to Anthony Hughes, QA Mentor (:ashughes) from comment #8) > Does this have in-testsuite coverage? No, not yet. I'm currently working on adding automated tests for this component in bug 952259.
Flags: needinfo?(mbrubeck)
Verified as fixed on Nightly (build ID: 20140122030521) and Aurora (build ID: 20140123004002) with Windows 8.1 32bit and 64bit architecture.
Status: RESOLVED → VERIFIED
status-firefox28: fixed → verified
status-firefox29: fixed → verified
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: