AFAICT OS.Constants.Path doesn't expose UAppData (XRE_USER_APP_DATA_DIR). This is preventing porting some nsIFile code to use OS.Path.

This should be pretty easy. The file to modify is dom/system/OSFileConstants.cpp. The code will be very similar to the existing code that defines OS.Constants.Path.desktopDir from key NS_OS_DESKTOP_DIR, except we would define OS.Constants.Path.userApplicationDataDir from key XRE_USER_APP_DATA_DIR.

Is this the correct way?

Comment on attachment 8358614 [details] [diff] [review] 958354 Review of attachment 8358614 [details] [diff] [review]: ----------------------------------------------------------------- Looks good, thanks. ::: dom/system/OSFileConstants.cpp @@ +91,5 @@ > * The user's desktop directory, if there is one. Otherwise this is > * the same as homeDir. > */ > nsString desktopDir; > + nsString userApplicationDataDir; Documentation would be nice.

Added documentation.

Comment on attachment 8358784 [details] [diff] [review] 958354 Review of attachment 8358784 [details] [diff] [review]: ----------------------------------------------------------------- Looks good. Before r+-ing, I'd like a test. Could you add one here? http://dxr.mozilla.org/mozilla-central/source/toolkit/components/osfile/tests/xpcshell/test_path_constants.js ::: dom/system/OSFileConstants.cpp @@ +103,5 @@ > + * UAppData = $HOME/.[$vendor/]$name > + * > + * Mac: > + * HOME = ~ > + * UAppData = $HOME/Library/Application Support/$name I suspect that it doesn't exist under Android. Is there a way you could check? @@ +875,5 @@ > return false; > } > > + if (!SetStringProperty(cx, objPath, "userApplicationDataDir", gPaths->userApplicationDataDir)) { > + return false; Nit: Too many spaces before the |return false|.

while going through code I realized that in http://dxr.mozilla.org/mozilla-central/source/dom/system/OSFileConstants.cpp#221 |"XpcomLib"| is hard coded. Should I change it to | NS_XPCOM_LIBRARY_FILE | as defined in http://dxr.mozilla.org/mozilla-central/source/xpcom/io/nsDirectoryServiceDefs.h#46 ? Is it ok to do this sort of corrections, or do we need to file new bug for that?

(In reply to Sumit Agrawal[:sumit4iit] from comment #7) > while going through code I realized that in > http://dxr.mozilla.org/mozilla-central/source/dom/system/OSFileConstants. > cpp#221 > |"XpcomLib"| is hard coded. Should I change it to | NS_XPCOM_LIBRARY_FILE | > as defined in > http://dxr.mozilla.org/mozilla-central/source/xpcom/io/ > nsDirectoryServiceDefs.h#46 ? Is it ok to do this sort of corrections, or do > we need to file new bug for that? You can do it if you want.