Etienne Segonzac (:etienne) Assignee
	Description • 11 years ago

Page 9 of the attached spec.

	Etienne Segonzac (:etienne) Assignee
	Comment 1 • 11 years ago

Note: the forwarding currently doesn't work for apps with APZC enabled, but I think we have a bug for that right?

	Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)
	Comment 2 • 11 years ago

Where is the attached spec ?

	Etienne Segonzac (:etienne) Assignee
	Comment 3 • 11 years ago

Ha. The PDF was too big for bugzilla, here's just this page.

	Etienne Segonzac (:etienne) Assignee
	Comment 4 • 11 years ago

Comment on attachment 8358491 [details]
Gaia PR

Clearing the r? until we find a solution for the APZC issue.

	Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)
	Comment 5 • 11 years ago

(In reply to Etienne Segonzac (:etienne) from comment #4)
> Comment on attachment 8358491 [details]
> Gaia PR
> 
> Clearing the r? until we find a solution for the APZC issue.

We have a solution now for APZC. you can re-ask r? when you want :)

	Etienne Segonzac (:etienne) Assignee
	Comment 6 • 11 years ago

Comment on attachment 8358491 [details]
Gaia PR

Ready for a new round of review :)

	Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)
	Comment 7 • 11 years ago

Comment on attachment 8358491 [details]
Gaia PR

A few nits. I think we should try to go with a TouchForwarder singleton since I can't imagine that we will really need multiple instances of it.

	Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)
	Comment 8 • 11 years ago

(In reply to Vivien Nicolas (:vingtetun) (:21) from comment #7)
> Comment on attachment 8358491 [details]
> Gaia PR
> 
> A few nits. I think we should try to go with a TouchForwarder singleton
> since I can't imagine that we will really need multiple instances of it.

As a small nit too I think you may want to send the touchend event into a setTimeout. Otherwise there is no highlight on the dialer keyboard for example.

	Etienne Segonzac (:etienne) Assignee
	Comment 9 • 11 years ago

Comment on attachment 8358491 [details]
Gaia PR

Keeping the TouchHandler instances as discussed IRL, fixed the other nits + the issue where we were sending a wrong tap.

	Etienne Segonzac (:etienne) Assignee
	Comment 10 • 11 years ago

\o/

	Etienne Segonzac (:etienne) Assignee
	Comment 11 • 11 years ago

https://github.com/mozilla-b2g/gaia/commit/11c3080559b0a975a53c10e0e63540079dc7d5d4