Closed
Bug 958993
Opened 11 years ago
Closed 11 years ago
taping "Clear" button under "Options" several times creates multiple modal prompts
Categories
(Firefox for Metro Graveyard :: Flyouts, defect, P2)
Tracking
(firefox28 verified, firefox29 verified)
VERIFIED
FIXED
Firefox 29
People
(Reporter: kjozwiak, Assigned: ally)
References
Details
(Whiteboard: [release28] [defect] p=3)
Attachments
(1 file)
(deleted),
patch
|
mbrubeck
:
review+
|
Details | Diff | Splinter Review |
If a user taps the "Clear" button under the "Options" flyout, it will create multiple instances of the modal window. If a "Clear Private Data" modal window is already visible, pressing the "Clear" button again shouldn't be creating another instance on top of the older one.
Steps to reproduce the issue:
1) Open Firefox Metro
2) Slide in the Windows Charm
3) Select "Settings" and than "Options"
4) Tap on the "Clear" button several times and you'll notice multiple instances of the modal window being created on top of each other
Current Behavior:
- Tapping on the "Create" button under the "Options" flyout creates multiple instances of the modal window
Expected Behavior:
- If a modal window is already visible, taping on "Clear" shouldn't be creating another instance on top of the older instance
Found the issue using the following build:
http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014-01-12-03-02-04-mozilla-central/
Updated•11 years ago
|
Whiteboard: [triage] [defect] p=0 → [release28] [defect] p=0
Comment 1•11 years ago
|
||
We could probably fix this by disabling the "clear" button when it's pressed and re-enabling it when the dialog closes.
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → ally
Assignee | ||
Updated•11 years ago
|
Whiteboard: [release28] [defect] p=0 → [release28] [defect] p=3
Assignee | ||
Comment 2•11 years ago
|
||
Attachment #8361402 -
Flags: review?(sfoster)
Comment 3•11 years ago
|
||
Comment on attachment 8361402 [details] [diff] [review]
clearDataBug_958993
Review of attachment 8361402 [details] [diff] [review]:
-----------------------------------------------------------------
woot! ship it!
Attachment #8361402 -
Flags: review?(sfoster) → review+
Assignee | ||
Comment 4•11 years ago
|
||
Comment 5•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 29
Comment 6•11 years ago
|
||
Temporarily reopening to add to Iteration #23 (Bug 961497)
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Updated•11 years ago
|
Status: REOPENED → RESOLVED
Closed: 11 years ago → 11 years ago
Resolution: --- → FIXED
Updated•11 years ago
|
Priority: -- → P2
Updated•11 years ago
|
QA Contact: jbecerra
Comment 7•11 years ago
|
||
status-firefox28:
--- → fixed
status-firefox29:
--- → fixed
Kamil, please verify this is fixed in the latest Nightly and Aurora builds.
Flags: needinfo?(kamiljoz)
Reporter | ||
Comment 9•11 years ago
|
||
Went through the following verification without any issues. Used the following builds:
- http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014-02-05-00-40-01-mozilla-aurora/
- http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014-02-05-03-02-03-mozilla-central/
- Ensured that the "Clear private data" modal window appears when taping/clicking on "Clear"
- Ensured that taping/clicking on "Clear" correctly clears the data that was selecting under the "Options" flyout
- Ensured that taping/clicking on the "Cancel" button correctly dismisses the "Clear private data" modal without clearing any data
- Ensured that the "Clear" button is disabled while the "Clear private data" modal window is opened
- Ensured that while the modal window is opened, you cannot click/tap on anything in the background (links, images, scrolling etc..)
- Ensured that when both "Browsing history" and "Other Data" are deselected, the "Clear" button is disabled
- Ensured that all of the above test cases also worked under snapped view
Marking this issue as verified as the original problem of the "Clear" button not being disabled initially has been resolved. However, I found another case were this could happen and created the following issue:
- Bug # 968534
Status: RESOLVED → VERIFIED
Flags: needinfo?(kamiljoz)
You need to log in
before you can comment on or make changes to this bug.
Description
•