Closed
Bug 959050
Opened 11 years ago
Closed 11 years ago
Remove some test files from the exclude list of b2g.json that are passing
Categories
(Testing :: Mochitest, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla29
People
(Reporter: martijn.martijn, Assigned: martijn.martijn)
References
Details
Attachments
(1 file, 2 obsolete files)
(deleted),
patch
|
emorley
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•11 years ago
|
||
Assignee | ||
Comment 2•11 years ago
|
||
Pushed to try: https://tbpl.mozilla.org/?tree=Try&rev=747f9b34deac
1171 added test passes.
Comment 3•11 years ago
|
||
We need to double check none of these intermittently fail - I've retriggered each mochitest job a number of times :-)
Comment 4•11 years ago
|
||
Comment on attachment 8359068 [details] [diff] [review]
b2g.json.diff
Review of attachment 8359068 [details] [diff] [review]:
-----------------------------------------------------------------
::: testing/mochitest/b2g.json
@@ -59,5 @@
> - "content/media/test/test_source_media.html": "",
> - "content/media/test/test_streams_element_capture.html": "bug 900172 - timeouts",
> - "content/media/test/test_streams_element_capture_reset.html": "bug 901102",
> - "content/media/test/test_streams_gc.html": "Value being assigned to HTMLMediaElement.currentTime is not a finite floating-point value",
> - "content/media/test/test_unseekable.html":"",
Note: the reason it appears the content/media/test/* entries are now passing is that the "content/media/test":"bug 918299" entry near the top is unilaterally disabling that directory and descendants, and so even with all the removals, the tests are not being run. At such point where bug 918299 is fixed and we re-enable that directory, it would be useful to have the specific entries still here to aid with greening up.
Assignee | ||
Comment 5•11 years ago
|
||
(In reply to Ed Morley [:edmorley UTC+0] from comment #3)
> We need to double check none of these intermittently fail - I've retriggered
> each mochitest job a number of times :-)
Yes, I would have done that too. But thanks for the help!
(In reply to Ed Morley [:edmorley UTC+0] from comment #4)
> Note: the reason it appears the content/media/test/* entries are now passing
> is that the "content/media/test":"bug 918299" entry near the top is
> unilaterally disabling that directory and descendants, and so even with all
> the removals, the tests are not being run. At such point where bug 918299 is
> fixed and we re-enable that directory, it would be useful to have the
> specific entries still here to aid with greening up.
Ok, we can leave it in. I'm not sure it's that useful to leave it in, though, that's why I removed it.
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → martijn.martijn
Assignee | ||
Comment 6•11 years ago
|
||
test_XHR_system.html is failing, so I readded that again.
Also, the content/media/test entries.
Attachment #8359068 -
Attachment is obsolete: true
Assignee | ||
Comment 7•11 years ago
|
||
Pushed to try again to make sure I didn't make a stupid mistake: https://tbpl.mozilla.org/?tree=Try&rev=548d2095bf83
Assignee | ||
Comment 8•11 years ago
|
||
Bug 959512 is now for test_XHR_system.html failing.
Comment 9•11 years ago
|
||
(In reply to Martijn Wargers [:mwargers] (QA) from comment #5)
> Ok, we can leave it in. I'm not sure it's that useful to leave it in,
> though, that's why I removed it.
Ah if it was intentional, happy to defer to you judgement - just didn't know if it had been missed :-)
Comment 10•11 years ago
|
||
s/you/your/
Assignee | ||
Comment 11•11 years ago
|
||
2nd try is all green. I don't care much if the content/media/test entries are in or not.
Keywords: checkin-needed
Assignee | ||
Updated•11 years ago
|
Attachment #8359650 -
Flags: review?(emorley)
Assignee | ||
Updated•11 years ago
|
Attachment #8359650 -
Flags: review?(emorley)
Assignee | ||
Comment 13•11 years ago
|
||
I had to unbitrot the patch, let me know if you need a try run for this latest patch again.
Attachment #8359650 -
Attachment is obsolete: true
Attachment #8360170 -
Flags: review?(emorley)
Comment 14•11 years ago
|
||
Comment on attachment 8360170 [details] [diff] [review]
b2g.json.diff
Thank you :-)
Attachment #8360170 -
Flags: review?(emorley) → review+
Assignee | ||
Comment 15•11 years ago
|
||
The patch is on top of the patch for bug 959512.
Assignee | ||
Updated•11 years ago
|
Keywords: checkin-needed
Comment 16•11 years ago
|
||
Flags: in-testsuite+
Keywords: checkin-needed
Comment 17•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
You need to log in
before you can comment on or make changes to this bug.
Description
•