Closed
Bug 959175
Opened 11 years ago
Closed 11 years ago
Force redrawing on uppercase-switching for Layouts with secondLayout set to true. Regression after 875963
Categories
(Firefox OS Graveyard :: Gaia::Keyboard, defect)
Tracking
(b2g-v1.3T fixed)
RESOLVED
FIXED
Tracking | Status | |
---|---|---|
b2g-v1.3T | --- | fixed |
People
(Reporter: nefzaoui, Assigned: janjongboom)
References
Details
Attachments
(1 file)
It seems like since after bug 875963, Layouts with secondLayout set to true are not being able to user the uppercase layout as a second view for the rest of the characters.
The perfect solution would be to force redrawing uppercase whenever we have secondLayout in a locale's layout
secondLayout was suggested in bug 942651
Assignee | ||
Comment 1•11 years ago
|
||
Fairly straightforward. We shouldn't do this behavior checking in render.js, so I moved that to keyboard.js and re-introduced the uppercase flag in render again. Now all logic is in keyboard.js, and the rendering in render.js. With tests around it.
Attachment #8359830 -
Flags: review?(rlu)
Attachment #8359830 -
Flags: feedback?(nefzaoui.ahmed)
Reporter | ||
Comment 2•11 years ago
|
||
Comment on attachment 8359830 [details]
Patch
Works like a charm :)
Attachment #8359830 -
Flags: feedback?(nefzaoui.ahmed)
Comment 3•11 years ago
|
||
Comment on attachment 8359830 [details]
Patch
r=me.
It was my fault that did not catch this at the beginning.
Jan, Ahmed, thanks for your help to make it right.
Attachment #8359830 -
Flags: review?(rlu) → review+
Assignee | ||
Comment 4•11 years ago
|
||
Good reason why we should increase our test coverage :-)
Landed in https://github.com/mozilla-b2g/gaia/commit/e553ba3a0cdf9b4bfaa4d946279e31a0eacb2806.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Comment 5•11 years ago
|
||
Uplifted to v1.3t,
https://github.com/mozilla-b2g/gaia/commit/9bd921d1b6b67a4903466de333d7c2f98a0d5cca
status-b2g-v1.3T:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•