Closed
Bug 959772
Opened 11 years ago
Closed 11 years ago
Create a generic PanelType and corresponding *Panel class for third-party panels
Categories
(Firefox for Android Graveyard :: Awesomescreen, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 29
People
(Reporter: Margaret, Assigned: Margaret)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
lucasr
:
review+
|
Details | Diff | Splinter Review |
PanelType.LIST was intended to do this, so let's just rename that to make it clear that it corresponds to panels that can be made to hold dynamic content, such as different sets of "widgets".
|
Assignee | |
Comment 1•11 years ago
|
||
Simple renaming patch, with some comments added to clarify some of our intentions.
We can work in bug 959777 to implement the real meat of this DynamicPanel class.
Attachment #8359982 -
Flags: review?(lucasr.at.mozilla)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 8359982 [details] [diff] [review]
patch
Review of attachment 8359982 [details] [diff] [review]:
-----------------------------------------------------------------
Awesome.
::: mobile/android/base/home/HomeConfig.java
@@ +24,5 @@
> TOP_SITES("top_sites", TopSitesPanel.class),
> BOOKMARKS("bookmarks", BookmarksPanel.class),
> HISTORY("history", HistoryPanel.class),
> READING_LIST("reading_list", ReadingListPanel.class),
> + DYNAMIC("dynamic", DynamicPanel.class);
nit: remove trailing space
Attachment #8359982 -
Flags: review?(lucasr.at.mozilla) → review+
|
|
Assignee | |
Comment 3•11 years ago
|
||
|
||
Comment 4•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 29
|
||
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•