Closed
Bug 959880
Opened 11 years ago
Closed 11 years ago
Support basic HTML markup in home banner text
Categories
(Firefox for Android Graveyard :: Awesomescreen, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 29
People
(Reporter: Margaret, Assigned: Margaret)
References
Details
Attachments
(1 file)
(deleted),
patch
|
wesj
:
review+
|
Details | Diff | Splinter Review |
This idea was mentioned and dismissed in bug 905262, but the mockups in bug 958891 include text that looks like a link. In order to do that, we'll need to add support for it.
Assignee | ||
Comment 1•11 years ago
|
||
I thought it would be easy to do this using Html.fromHtml, but it looks like TextView.setText doesn't accept HTML-style formatting:
http://developer.android.com/reference/android/widget/TextView.html#setText%28java.lang.CharSequence%29
In order to do what we want for bug 958891 (adding a link), we may need to do something like what we do for doorhangers:
http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/widget/DoorHanger.java#170
However, this would involve changing the Home.banner API to specify some link text or something, since this would have to happen in Java.
Assignee | ||
Comment 2•11 years ago
|
||
Doh, my testcase was just bad. This actually was easy to implement.
Attachment #8360579 -
Flags: review?(wjohnston)
Updated•11 years ago
|
Attachment #8360579 -
Flags: review?(wjohnston) → review+
Assignee | ||
Comment 3•11 years ago
|
||
Comment 4•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 29
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•