Closed Bug 959880 Opened 11 years ago Closed 11 years ago

Support basic HTML markup in home banner text

Categories

(Firefox for Android Graveyard :: Awesomescreen, defect)

ARM
Android
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 29

People

(Reporter: Margaret, Assigned: Margaret)

References

Details

Attachments

(1 file)

This idea was mentioned and dismissed in bug 905262, but the mockups in bug 958891 include text that looks like a link. In order to do that, we'll need to add support for it.
I thought it would be easy to do this using Html.fromHtml, but it looks like TextView.setText doesn't accept HTML-style formatting: http://developer.android.com/reference/android/widget/TextView.html#setText%28java.lang.CharSequence%29 In order to do what we want for bug 958891 (adding a link), we may need to do something like what we do for doorhangers: http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/widget/DoorHanger.java#170 However, this would involve changing the Home.banner API to specify some link text or something, since this would have to happen in Java.
Attached patch patch (deleted) — Splinter Review
Doh, my testcase was just bad. This actually was easy to implement.
Attachment #8360579 - Flags: review?(wjohnston)
Attachment #8360579 - Flags: review?(wjohnston) → review+
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 29
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: