Closed Bug 959920 Opened 11 years ago Closed 11 years ago

[DSDS][fugu] add a new quirk for radio control

Categories

(Firefox OS Graveyard :: Vendcom, defect)

x86_64
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: hsinyi, Unassigned)

References

Details

(Whiteboard: [POVB])

We need a new quirk "ro.moz.ril.radio_off_wo_card" setting to true for controlling fugu dsds radio correctly.
Blocks: 943215
blocking-b2g: --- → 1.3?
Hi Sam, Could you please help this bug? We need the new quirk added to your git repo. Thanks!
Flags: needinfo?(sam.hua)
2 in device/sprd/sp7710gaplus_gonk/base.mk PRODUCT_PROPERTY_OVERRIDES := \ ro.moz.omx.hw.max_width=720 \ ro.moz.omx.hw.max_height=576 \ ro.moz.ril.query_icc_count=true \ ro.moz.mute.call.to_ril=true \ ro.moz.ril.numclients=2 \ ro.moz.ril.data_reg_on_demand=true changed to PRODUCT_PROPERTY_OVERRIDES := \ ro.moz.omx.hw.max_width=720 \ ro.moz.omx.hw.max_height=576 \ ro.moz.ril.query_icc_count=true \ ro.moz.mute.call.to_ril=true \ ro.moz.ril.numclients=2 \ ro.moz.ril.data_reg_on_demand=true\ ro.moz.ril.radio_off_wo_card=true
Flags: needinfo?(sam.hua)
Whiteboard: [POVB]
Whiteboard: [POVB] → [POVB, dsdsrun1.3-2]
I've verified the quirk has been added to fugu dsds. Thanks!
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [POVB, dsdsrun1.3-2] → [POVB]
Clearing nom - this is vendor specific.
blocking-b2g: 1.3? → ---
Sam, I saw one of your sprd commits saying "Bug #273645 disable ro.moz.ril.radio_off_wo_card function because it isn't ready." May I understand more about this? What's the problem you are facing? And is there anything that gecko could/should do for radio control on fugu? Thanks!
Flags: needinfo?(sam.hua)
REOPEN this because it has been backed out from partner's repo. Waiting for their confirmation.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Hi Hsin, it is because the phone can't find the the network of SIM2. it doesn't send RADIO_POWER(1) to RILC. I am checking the newest code. if it works, i will add it
Flags: needinfo?(sam.hua)
(In reply to sam.hua from comment #7) > Hi Hsin, > it is because the phone can't find the the network of SIM2. it doesn't send > RADIO_POWER(1) to RILC. > > I am checking the newest code. if it works, i will add it Thanks for the reply, Sam. If the problem you are facing is the phone can't find the the network of SIM2, I believe bug 963054 comment 3 already points the root cause. We should have a fix for bug 963054 and in the meanwhile, we add the quirk back. What do you think?
Flags: needinfo?(sam.hua)
yes,of course. but the latest build still has this problem. if u do need it now, i can add it back.
Flags: needinfo?(sam.hua)
(In reply to sam.hua from comment #9) > yes,of course. but the latest build still has this problem. > > if u do need it now, i can add it back. As we know the root cause of the problem of SIM2 network searching, I think the right direction would be fixing that on bug 963054. Removing this quirk doesn't really help resolve the issue. Instead, it distracts the whole testing process and makes us mis-report a bunch of regression bugs. Therefore, I'd like to ask for your help to add this back. Thank you, Sam.
Hi Hsin, I can't add it back because i have to give our test team the build which support dual sim cards.
Depends on: 963054
Hi Sam, One of the blocker of fugu radio control, bug 963054, has landed. Please check if we are fine to add the quirk back. Thank you for the help.
Flags: needinfo?(sam.hua)
OK. I will confirm it with latest build.
Flags: needinfo?(sam.hua)
OK. I will confirm it with latest build.
Hi Sam, Do you have latest update of this bug? We would need to build latest base image to continue our test or based on Hsinyi's comment that single SIM cases will be impacted by this bug.
Flags: needinfo?(sam.hua)
Sam, If I didn't misunderstand your comment https://bugzilla.mozilla.org/show_bug.cgi?id=963054#c54, the quirk should have been added back to your repo. I repo syned this morning and didn't see it yet. Please inform us if the quirk is ready in the repo. Thank you!
Blocks: 975999
Blocks: 976001
it is updated now,please check it.
Flags: needinfo?(sam.hua)
Which branch should I check? sprd-aosp/sprdroid4.0_bsp? I don't see it yet...
I confirmed this quirk has been added back to repo. Thanks, Sam.
Status: REOPENED → RESOLVED
Closed: 11 years ago11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.