Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi] Reporter
	Description • 11 years ago

Like Bluetooth, when we enable NFC there should be an icon for telling user NFC has been enabled.

	Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi] Reporter
	Comment 1 • 11 years ago

Hi Ken
I think it's a very basic feature for NFC. It should be 1.4+

	Ken Chang[:kenkai]
	Comment 2 • 11 years ago

I wonder if UX team can design this for NFC. By the way, there isn't a NFC status bar in other devices, you could double check it again. Partner also request this, so please talk with them. But I wonder if it is a vendor specific feature.

	Juwei Huang[:juwei]
	Comment 3 • 11 years ago

We've already updated this icon months ago,
Please check https://github.com/mozilla-b2g/gaia/tree/master/apps/system/style/statusbar/images

	Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi] Reporter
	Comment 4 • 11 years ago

request to 1.5+

	Ken Chang[:kenkai]
	Comment 5 • 11 years ago

Wesley, who can help this in Gaia.

	Wesley Huang [:wesley_huang] (EPM) (NI me)
	Comment 6 • 11 years ago

Candice, is this in systemfe's plate?

	Candice Serran (:cserran)
	Comment 7 • 11 years ago

(In reply to Wesley Huang [:wesley_huang] from comment #6)
> Candice, is this in systemfe's plate?

Yes, confirmed this is systemsfe bug. Updating whiteboard tag and added to our backlog.

	Peter Dolanjski [:pdol]
	Comment 8 • 11 years ago

I'm moving this to backlog for now.  I fully acknowledge that it is quite important for NFC to inform the user of status, but it is not clear that we'll block 1.5 on NFC at this point.  If that changes, we can definitely bump it up.

	Ken Chang[:kenkai]
	Comment 9 • 11 years ago

Wesley, I think NFC is one of key features in 1.5, right?

	Wesley Huang [:wesley_huang] (EPM) (NI me)
	Comment 10 • 11 years ago

Yes. NFC (sharing) is key focus in 1.5, so there will be obvious user interactions.
Suggest to implement this icon per defined by UX.

	Wesley Huang [:wesley_huang] (EPM) (NI me)
	Comment 11 • 11 years ago

Just realized this status icon is needed for partner in 1.5 timeframe.(bug 972778)
Set to 1.5? again.

	Wayne Chang [:wchang]
	Comment 12 • 11 years ago

For triage information - this is requested by partners as mentioned in comment 11 and they are unable to take this one.

	Wesley Huang [:wesley_huang] (EPM) (NI me)
	Comment 13 • 11 years ago

NFC p2p sharing is defined as key focus in 2.0, so I'm setting this + for this is obvious user experience flaw.

	gasolin@mozilla.com Assignee
	Comment 15 • 11 years ago

@greg I mapped NFC stat 0(NFC_HW_STATE_OFF)-> hide icon , 1~3-> show icon on statusbar.

	Greg Weng [:snowmantw][:gweng][:λ]
	Comment 16 • 11 years ago

Should ask Yoshi that if `NFC_HW_STATE_DISABLE_DISCOVERY` means it's active.

	Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi] Reporter
	Comment 17 • 11 years ago

(In reply to Greg Weng [:snowmantw][:gweng][:λ] from comment #16)
> Should ask Yoshi that if `NFC_HW_STATE_DISABLE_DISCOVERY` means it's active.

It means in low power mode, it cannot detect nor get detected,
but the hardware is still enabled.

	Greg Weng [:snowmantw][:gweng][:λ]
	Comment 18 • 11 years ago

So it should be treated as inactive?

	Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi] Reporter
	Comment 19 • 11 years ago

When in low power mode, it still could be in card emulation mode, which is related to payment.
But we don't support it for now.

We could file a new bug to discuss this special case.

	gasolin@mozilla.com Assignee
	Comment 20 • 11 years ago

So it sounds like `stat 0(NFC_HW_STATE_OFF)-> hide icon` is right in current stage.

Do you know how other platform the NFC status is displayed in low power mode?

	Greg Weng [:snowmantw][:gweng][:λ]
	Comment 21 • 11 years ago

Asked Juwei (UX): it's OK to show the icon at the `NFC_HW_STATE_DISABLE_DISCOVERY` state.

So Comment 15 is a correct way to implement this.

	Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi] Reporter
	Comment 22 • 11 years ago

LG Nexus 5 doesn't have icon for NFC.
Sony still shows NFC icon in low power mode.

Sorry I don't know about Samsung.

	gasolin@mozilla.com Assignee
	Comment 23 • 11 years ago

Comment on attachment 8411552 [details]
pull request redirect to github

travis passed

	(inactive after 6/18) Alive Kuo [:alive]
	Comment 24 • 11 years ago

Comment on attachment 8411552 [details]
pull request redirect to github

r+ if event name is changed and unit test for nfcmanager part

	gasolin@mozilla.com Assignee
	Comment 25 • 11 years ago

add nfc_manager test case and merged to gaia-master https://github.com/mozilla-b2g/gaia/commit/ed00198def12a2df82fb8e4277fa5c3ed2471dd5

thanks!