KTucker [:KTucker][Inactive 3/4/2016] Reporter
	Description • 11 years ago

Description:
The "Edit contact" view closes after tapping on an email address in a SMS and then trying to add a photo and more info to a linked Facebook contact. 

Perquisite: Manually created contact that has a First Name and Phone number. Facebook contacts have been imported to Contacts.

Repro Steps:
1)  Updated Buri to Build ID: 20140115004003
2)  Receive a SMS from another phone to the test phone that has an email address. 
3)  Tap on the that email address in the message thread on the test phone.
4)  Tap on "Add to an exiting contact". 
5)  Tap on an existing contact that has been linked to a Facebook account. 
6)  Tap on "Add Picture" and add a picture to the linked contact.
7)  Tap on the "Company" text field and enter in a company.

Actual:
The edit contact view window closes by itself when adding a email address from a SMS and then trying to add a picture and more info to a linked Facebook contact. 

Expected:
The user is able to add an email address from a SMS, a photo and more information to a linked Facebook contact without issue. 

Environmental Variables
Device: Buri v 1.3.0 Mozilla RIL
Build ID: 20140115004003
Gecko: http://hg.mozilla.org/releases/mozilla-aurora/rev/d7260b206e91
Gaia: 14e199d6a9ad917eacad883820a9f7619dbf42c8
Platform Version: 28.0a2

Notes:
Repro frequency: 100%
Link to failed test case: https://moztrap.mozilla.org/manage/case/7179/
See attached: video clip, logcat

	KTucker [:KTucker][Inactive 3/4/2016] Reporter
	Comment 1 • 11 years ago

Correction to Prerequisite above the repro steps. The manually created contact should be linked to a imported Facebook contact.

	Francisco Jordano [:arcturus] [:francisco]
	Comment 3 • 11 years ago

Hi,

I've been following the steps to reproduce and what is happening is the contacts app get killed after invoking the postResult from the gallery. And that seems that it returned back to SMS, but what really happened is that we sms + contacts + gallery == killing the phone.

Some error traces

E/GeckoConsole(  450): [JavaScript Error: "NS_ERROR_NOT_INITIALIZED: Component returned failure code: 0xc1f30001 (NS_ERROR_NOT_INITIALIZED) [nsIMessageSender.sendAsyncMessage]" {file: "resource://gre/modules/ActivitiesService.jsm" line: 303}]
E/GeckoConsole(  450): Content JS WARN at app://system.gaiamobile.org/js/activity_window.js:233 in onClose: unknown window type of activity caller.

There another bug where we talk about the cycle of activities, here is the same, before for adding something (tel or email) to a contact via activity, we were not going to the detail view, just the list and once we clicked, we returned back to the app, not showing the details.

I think I nee Ayman input here again :(

Cheers!

	ayman maat :maat
	Comment 4 • 11 years ago

ok, I can reproduce this. :( 

However at the moment I am unsure from a UX PoV how i can help as the path of adding an email address to an existing linked contact via the message app and then adding some more information to the same contact whilst in edit mode is not an unreasonable or illogical one for the user to follow.

Never the less the crashing of the Contacts app (or any other app) is unacceptable and we clearly need to address this. 

Lets talk and see what we can do and how i can help.

	Andrew Stole [:astole]
	Comment 5 • 11 years ago

I was able to repro this with slightly different steps.

Repro Steps:
1)  Updated Buri to BuildID: 20140117004005
2)  Receive a SMS from another phone to the test phone that has an email address. 
3)  Tap on the that email address in the message thread on the test phone.
4)  Tap on "Add to an existing contact". 
5)  Tap on an existing contact that has been linked to a Facebook account. 
6)  Tap on "Add Picture", crop a picture from the gallery and tap "Done".
7)  Tap on "Add Picture" again, select a picture from the gallery and tap "Done".

Actual:
After selecting "Done" in Step 7, the user is brought back to the SMS.

Expected:
The user is able to add an email address from a SMS, a photo and more information to a linked Facebook contact without issue

Environmental Variables:
Device: Buri v1.3 Mozilla RIL
BuildID: 20140117004005
Gaia: a81ccdc53e45a6adeaae423e104e91bcc1e12b0e
Gecko: 2c033140eff4
Version: 28.0a2
Firmware Version: v1.2-device.cfg

	Josh Schmitt [Joshs]
	Comment 6 • 11 years ago

It appears that this issue has always occurred on 1.3, happened in the first build of 1.3

Environmental Variables:
Device: Buri 1.3 MOZ
BuildID: 20130919040201
Gaia: 0dedb5b3789afc638a0c7c67652937fcb30e77d2
Gecko: 803189f35921
Version: 27.0a1
RIL Version: 01.02.00.019.102
Firmware Version: V1.2-device.cfg

	Gabriele Svelto [:gsvelto] Assignee
	Comment 7 • 11 years ago

I've tried to reproduce this and I can do it without having to import Facebook contacts at all. Loading the light reference workload is enough. This bug is caused by bug 892371 and cannot really be fixed without fixing it. In a nutshell in 1.3 all activities in the communications app have been changed from "window" to "inline". In the scenario above this causes the three opened applications (sms, communications and gallery) to be considered all open and in the foreground at the same time. In these conditions when we finishing picking the image in the gallery app memory usage spikes due to the allocation of the image blob and one of the other apps is killed to free up some memory. Since the three applications are all in the foreground the low-memory killer logic picks the largest (which happens to be communications in this case).

Since there's no chances of fixing bug 892371 in the 1.3 timeframe I'll try the approach we used in bug 959422 to reduce the memory footprint of the attached image in the hope of fixing the problem.

	Gabriele Svelto [:gsvelto] Assignee
	Comment 9 • 11 years ago

Could you try to reproduce the bug with the patch in attachment 8366757 [details] [diff] [review] applied? I did a few tests and I cannot reproduce the issue using the STR in comment 0. I can still reproduce the issue with the STR in comment 5 and I'm investigating it to see if there's a way to fix it that does not involve fixing bug 892371.

	Jason Smith [:jsmith]
	Comment 10 • 11 years ago

(In reply to Gabriele Svelto [:gsvelto] from comment #9)
> Could you try to reproduce the bug with the patch in attachment 8366757 [details] [diff] [review]
> [details] [diff] [review] applied? I did a few tests and I cannot reproduce
> the issue using the STR in comment 0. I can still reproduce the issue with
> the STR in comment 5 and I'm investigating it to see if there's a way to fix
> it that does not involve fixing bug 892371.

To make things a bit easier - can you put this patch into a gaia branch in your github that Kevin can pull locally for testing?

	Gabriele Svelto [:gsvelto] Assignee
	Comment 11 • 11 years ago

(In reply to Jason Smith [:jsmith] from comment #10)
> To make things a bit easier - can you put this patch into a gaia branch in
> your github that Kevin can pull locally for testing?

Sure, I'm attaching a pull request and the branch is here:

https://github.com/gabrielesvelto/gaia/tree/bug-960280-reduce-canvas-memory

	KTucker [:KTucker][Inactive 3/4/2016] Reporter
	Comment 12 • 11 years ago

Tried reproducing this issue using Gabriele's patch but i keep getting an Invalid App ID: 123456 error when trying to import contacts from Facebook.

	Jason Smith [:jsmith]
	Comment 13 • 11 years ago

(In reply to ktucker from comment #12)
> Tried reproducing this issue using Gabriele's patch but i keep getting an
> Invalid App ID: 123456 error when trying to import contacts from Facebook.

You need to build gaia with MOZILLA_OFFICIAL=1. Otherwise, you'll hit this error.

	KTucker [:KTucker][Inactive 3/4/2016] Reporter
	Comment 14 • 11 years ago

I cannot reproduce this issue using the original steps on the provided patch. However, I can still reproduce the issue using the STR from Comment 5  

Also, the keyboard does not seem to want to pop up when tapping on the "Company" field in edit contact. The user has to tap on the field many times to finally get the keyboard to appear. I don't know if this is relevant but i thought i would bring it to your attention.

	Gabriele Svelto [:gsvelto] Assignee
	Comment 15 • 11 years ago

(In reply to ktucker from comment #14)
> I cannot reproduce this issue using the original steps on the provided
> patch. However, I can still reproduce the issue using the STR from Comment 5

Thank you for testing. Fixing the STR in comment 5 requires fixing bug 892371; fixing the original issue however is enough to close this bug.

> Also, the keyboard does not seem to want to pop up when tapping on the
> "Company" field in edit contact. The user has to tap on the field many times
> to finally get the keyboard to appear. I don't know if this is relevant but
> i thought i would bring it to your attention.

Thanks for pointing it out; it's probably caused by the lack of memory and I'll have to check it out too.

	Etienne Segonzac (:etienne)
	Comment 16 • 11 years ago

Comment on attachment 8366757 [details] [diff] [review]
[PATCH] Generate canvases that are not displayed with the appropriate tag to reduce memory usage

Redirecting to my favorite Contacts peer :)

	Francisco Jordano [:arcturus] [:francisco]
	Comment 17 • 11 years ago

Comment on attachment 8366757 [details] [diff] [review]
[PATCH] Generate canvases that are not displayed with the appropriate tag to reduce memory usage

r+

Thanks Gabrielle!

	Gabriele Svelto [:gsvelto] Assignee
	Comment 18 • 11 years ago

Travis run: https://travis-ci.org/mozilla-b2g/gaia/builds/17907423

Pushed to gaia/master 5df7622aa7456415503dc374a9b80a5fce40dc58

	Gabriele Svelto [:gsvelto] Assignee
	Comment 19 • 11 years ago

Pushed to gaia/v1.3 e82141240c863cb1dac7ebd46bd3dcc717d39b4a