Closed
Bug 960357
Opened 11 years ago
Closed 11 years ago
Disable the Downloads API debugging spew by default
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla29
People
(Reporter: reuben, Assigned: reuben)
References
Details
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
fabrice
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•11 years ago
|
||
Assignee: nobody → reuben.bmo
Attachment #8360789 -
Flags: review?(fabrice)
Comment 2•11 years ago
|
||
Comment on attachment 8360789 [details] [diff] [review]
Disable the debugging spew by default
Review of attachment 8360789 [details] [diff] [review]:
-----------------------------------------------------------------
Could you #ifdef MOZ_DEBUG instead of commenting?
Attachment #8360789 -
Flags: review?(fabrice)
Why do we want this spew in debug builds?
Assignee | ||
Comment 4•11 years ago
|
||
Sure, I just did what other JS-implemented stuff does.
Attachment #8360789 -
Attachment is obsolete: true
Attachment #8360796 -
Flags: review?(fabrice)
Comment 5•11 years ago
|
||
Comment on attachment 8360796 [details] [diff] [review]
Disable the debugging spew by default, v2
Review of attachment 8360796 [details] [diff] [review]:
-----------------------------------------------------------------
r=me
I'd rather have better LOG facilities that we can turn on with env variables for js like for c++, but I don't think we have that for js.
Attachment #8360796 -
Flags: review?(fabrice) → review+
Assignee | ||
Comment 6•11 years ago
|
||
Comment 7•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•