Closed Bug 961204 Opened 11 years ago Closed 11 years ago

Remove the my_context bits from nsWindowSH::NewResolve

Categories

(Core :: DOM: Core & HTML, defect)

Product:
Core
Component:
DOM: Core & HTML
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla29

People

(Reporter: bzbarsky, Assigned: bzbarsky)

References

Details

(Whiteboard: [qa-])

Attachments

(3 files, 1 obsolete file)

Same thing as diff -w
(deleted), patch
Details | Diff | Splinter Review
Let's have the browser start too
(deleted), patch
bholley
: review+
Details | Diff | Splinter Review
Interdiff from previous patch
(deleted), patch
Details | Diff | Splinter Review
As far as we can tell, they're not really used.
Assignee: nobody → bzbarsky
Status: NEW → ASSIGNED
Attached patch Same thing as diff -w (deleted) — — Splinter Review
Whiteboard: [need review]
Comment on attachment 8361888 [details] [diff] [review] Remove the my_context bits from nsWindowSH::NewResolve and just use the passed-in cx for everything. Review of attachment 8361888 [details] [diff] [review]: ----------------------------------------------------------------- lgtm
Attachment #8361888 - Flags: review?(bobbyholley+bmo) → review+
Comment on attachment 8361888 [details] [diff] [review] Remove the my_context bits from nsWindowSH::NewResolve and just use the passed-in cx for everything. Review of attachment 8361888 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/base/nsDOMClassInfo.cpp @@ +3371,5 @@ > bool did_resolve = false; > bool ok = true; > JS::Rooted<JS::Value> exn(cx, JSVAL_VOID); > > + ok = JS_ResolveStandardClass(cx, obj, id, &did_resolve); No need for the ok local anymore
Attachment #8362016 - Flags: review?(bobbyholley+bmo)
Attachment #8361888 - Attachment is obsolete: true
Attached patch Interdiff from previous patch (deleted) — — Splinter Review
Comment on attachment 8362016 [details] [diff] [review] Let's have the browser start too Review of attachment 8362016 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/base/nsDOMClassInfo.cpp @@ +3416,5 @@ > > return NS_OK; > } > > + // WebIDL quickstubs handle location for us, but Xrays don't see those. So if This comment needs fixing. r=bholley with that.
Attachment #8362016 - Flags: review?(bobbyholley+bmo) → review+
Flags: in-testsuite-
Whiteboard: [need review]
Target Milestone: --- → mozilla29
Blocks: 933724
Whiteboard: [qa-]
Depends on: 988863
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: