Boris Zbarsky [:bzbarsky] Assignee
	Description • 11 years ago

Then they can easily control what property flags should be used for the property.

	Boris Zbarsky [:bzbarsky] Assignee
	Comment 1 • 11 years ago

Please verify my verification that the callees are OK with this!

	Bobby Holley (:bholley)
	Comment 3 • 11 years ago

Comment on attachment 8361933 [details] [diff] [review]
part 1.  When doing a DoNewResolve for Xrays, pass the Xray, not the underlying object, to DoNewResolve, in case people want to do permissions checks on the object.

Review of attachment 8361933 [details] [diff] [review]:
-----------------------------------------------------------------

Navigator and ObjectLoadingContent seem fine. Are those the only two?

	Bobby Holley (:bholley)
	Comment 4 • 11 years ago

Comment on attachment 8361934 [details] [diff] [review]
part 2.  Change the WebIDL DoNewResolve hook signature to take a JSPropertyDescriptor.

Review of attachment 8361934 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/bindings/Codegen.py
@@ +6004,4 @@
>                  "  return true;\n"
>                  "}\n"
> +                "if (!JS_DefinePropertyById(cx, obj, id, desc.value(),\n"
> +                "                           desc.getter(), desc.setter(),\n"

Note that this will cause the class getter to be invoked, if one exists (if you want no getter, you need to pass JS_PropertyStub). But this isn't a behavioral change, and is probably fine.

	Boris Zbarsky [:bzbarsky] Assignee
	Comment 5 • 11 years ago

> Navigator and ObjectLoadingContent seem fine. Are those the only two?

So far, yes.

> Note that this will cause the class getter to be invoked, if one exists

Yeah, these are WebIDL objects, so they never have those.  ;)

	Bobby Holley (:bholley)
	Comment 7 • 11 years ago

Comment on attachment 8363094 [details] [diff] [review]
part 2.  Change the WebIDL DoNewResolve hook signature to take a JSPropertyDescriptor.

Review of attachment 8363094 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/bindings/Codegen.py
@@ +6004,5 @@
>                  "  return true;\n"
>                  "}\n"
> +                "// If desc.value() is undefined, then the DoNewResolve call\n"
> +                "// has already defined it on the object.  Don't try to also\n"
> +                "// define it.\n"

I'm assuming more comments will come later when we hook this stuff up for window?

	Boris Zbarsky [:bzbarsky] Assignee
	Comment 8 • 11 years ago

   https://hg.mozilla.org/integration/mozilla-inbound/rev/c7b17f121aee
   https://hg.mozilla.org/integration/mozilla-inbound/rev/38aea88101ba

	Carsten Book [:Tomcat]
	Comment 9 • 11 years ago

https://hg.mozilla.org/mozilla-central/rev/c7b17f121aee
https://hg.mozilla.org/mozilla-central/rev/38aea88101ba