Wifi network list isn't displayed, and always display scanning.

Comment on attachment 8362333 [details] [diff] [review] bug-961485-fix.patch Review of attachment 8362333 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/wifi/WifiUtils.cpp @@ +242,5 @@ > + DEFINE_DLFUNC(wifi_command, int32_t, const char*, char*, size_t*) > + int32_t do_wifi_command(const char* iface, const char* cmd, char* buf, size_t* len) { > + char command[COMMAND_SIZE]; > + if (!strcmp(iface,"p2p0")) { > + // commands for p2p0 interface don't need prefix Nit: capitalize the first letter, period at the end of the sentence please. ::: dom/wifi/WifiWorker.js @@ +636,5 @@ > + if (event.indexOf("IFNAME=") === 0) > + { > + // Jump over IFNAME for gonk-kk. > + event = event.substr(event.indexOf(" ") + 1); > + } Can you explain why do we need this ?

In gonk-kk, the in coming event is in this format "IFNAME=wlan0 CTRL-EVENT-......". This will break consecutive condition check and always enter this checking and return; if (event.indexOf("CTRL-EVENT-") !== 0 && event.indexOf("WPS") !== 0) { ... }

(In reply to Kai-Zhen Li from comment #3) > In gonk-kk, the in coming event is in this format "IFNAME=wlan0 > CTRL-EVENT-......". > > This will break consecutive condition check and always enter this checking > and return; > > if (event.indexOf("CTRL-EVENT-") !== 0 && event.indexOf("WPS") !== 0) { > ... > } How do you think if we move version dependent codes to WifiUtils.cpp ?

Have version dependent codes in cpp files.

Comment on attachment 8362750 [details] [diff] [review] Hanlde IFNAME of wifi command for gonk-kk Review of attachment 8362750 [details] [diff] [review]: ----------------------------------------------------------------- r=me with nit fixed. ::: dom/wifi/WifiUtils.cpp @@ +241,5 @@ > + > + DEFINE_DLFUNC(wifi_command, int32_t, const char*, char*, size_t*) > + int32_t do_wifi_command(const char* iface, const char* cmd, char* buf, size_t* len) { > + char command[COMMAND_SIZE]; > + if (!strcmp(iface,"p2p0")) { nit: space after ','

fixed nit and update reviewer.

Try result: https://tbpl.mozilla.org/?tree=Try&rev=a1a678411ae8