Closed
Bug 961560
Opened 11 years ago
Closed 11 years ago
Create/use a SUMO topic redirect for the missing plugin URL
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(firefox26 wontfix, firefox27 fixed, firefox28 fixed, firefox29 fixed, fennec+)
RESOLVED
FIXED
Firefox 29
People
(Reporter: reuben, Assigned: u454397)
References
Details
(Keywords: verifyme)
Attachments
(1 file)
(deleted),
patch
|
Margaret
:
review+
bajaj
:
approval-mozilla-aurora+
bajaj
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
The missing plugin error message links to a 404 page in SUMO:
https://mxr.mozilla.org/mozilla-central/source/mobile/android/chrome/content/PluginHelper.js#268
This was caused because bug 702319 changed app.support.baseURL to use SUMO topic redirects like desktop does, but didn't update its users.
Reporter | ||
Comment 1•11 years ago
|
||
Ricky, can you create the mobile-flash-unsupported redirect, pointing to https://support.mozilla.org/kb/why-cant-firefox-mobile-play-flash-on-my-device ?
Margaret, can you also confirm if that's the article we want to link to?
Attachment #8362326 -
Flags: review?(margaret.leibovic)
Flags: needinfo?(rrosario)
Comment 2•11 years ago
|
||
(In reply to Reuben Morais [:reuben] from comment #1)
> Ricky, can you create the mobile-flash-unsupported redirect, pointing to
> https://support.mozilla.org/kb/why-cant-firefox-mobile-play-flash-on-my-
> device ?
Done!
Flags: needinfo?(rrosario)
Comment 3•11 years ago
|
||
Comment on attachment 8362326 [details] [diff] [review]
Use a SUMO redirect in the Learn More link
Review of attachment 8362326 [details] [diff] [review]:
-----------------------------------------------------------------
Thanks for catching this. I did a quick search to check for the other places we use app.support.baseURL, and the only other place we point to a specific article is for the telemetry link in bug 702319, so we shouldn't need to do any more fixes.
Attachment #8362326 -
Flags: review?(margaret.leibovic) → review+
Comment 4•11 years ago
|
||
Also, which versions of Firefox does this affect? Bug 702319 landed a long time ago. We should see if we can uplift this if it's currently affecting all versions.
tracking-fennec: --- → ?
Flags: needinfo?(reuben.bmo)
Reporter | ||
Comment 5•11 years ago
|
||
(In reply to :Margaret Leibovic from comment #4)
> Also, which versions of Firefox does this affect? Bug 702319 landed a long
> time ago. We should see if we can uplift this if it's currently affecting
> all versions.
All of them, it seems:
https://hg.mozilla.org/releases/mozilla-release/file/29657549d158/mobile/android/app/mobile.js#l456
https://hg.mozilla.org/releases/mozilla-release/file/29657549d158/mobile/android/chrome/content/PluginHelper.js#l273
Flags: needinfo?(reuben.bmo)
Keywords: checkin-needed
Comment 6•11 years ago
|
||
Comment on attachment 8362326 [details] [diff] [review]
Use a SUMO redirect in the Learn More link
[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 702319
User impact if declined: the missing plugin error message links to a 404 page in SUMO
Testing completed (on m-c, etc.): only tested locally
Risk to taking this patch (and alternatives if risky): low-risk, changes URL for an in-product SUMO link
String or IDL/UUID changes made by this patch: none
Attachment #8362326 -
Flags: approval-mozilla-beta?
Attachment #8362326 -
Flags: approval-mozilla-aurora?
Comment 7•11 years ago
|
||
Comment 8•11 years ago
|
||
Looks like a very low risk change, I am approving it on branches in parallel to m-c, so it can land today and get into our beta going to build soon.
Updated•11 years ago
|
status-firefox26:
--- → wontfix
status-firefox27:
--- → affected
status-firefox28:
--- → affected
status-firefox29:
--- → affected
Updated•11 years ago
|
Attachment #8362326 -
Flags: approval-mozilla-beta?
Attachment #8362326 -
Flags: approval-mozilla-beta+
Attachment #8362326 -
Flags: approval-mozilla-aurora?
Attachment #8362326 -
Flags: approval-mozilla-aurora+
Updated•11 years ago
|
tracking-fennec: ? → +
Comment 9•11 years ago
|
||
Comment 10•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 29
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•