Closed
Bug 961675
Opened 11 years ago
Closed 10 years ago
Send device information to Everything.me Partners API
Categories
(Firefox OS Graveyard :: Gaia::Everything.me, defect)
Tracking
(feature-b2g:2.0, tracking-b2g:backlog, b2g-v2.0 fixed)
RESOLVED
FIXED
2.0 S3 (6june)
Tracking | Status | |
---|---|---|
b2g-v2.0 | --- | fixed |
People
(Reporter: amirn, Assigned: amirn)
References
Details
(Whiteboard: [systemsfe])
User Story
We should send: - OS version - language - timezone - keyboard locale
Attachments
(1 file)
No description provided.
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → amirn
Assignee | ||
Comment 1•11 years ago
|
||
work started, waiting for keyboard.current replacement for 1.4 (bug 930402)
https://github.com/EverythingMe/gaia/commit/5834196de238f7f4e3298d8f29027b67c2046c9c
Comment 2•11 years ago
|
||
Hi Amir!
There isn't any proposed replacement for now. Probing |keyboard.current| will continue to work with built-in keyboard. Not sure about the new keyboard through, looping :djf.
Flags: needinfo?(dflanagan)
Comment 3•11 years ago
|
||
Tim,
Thanks for looping me in. As we move to 3rd party keyboards that are OOP and not certified, the keyboard app will not be able to set keyboard.current. Would system/js/keyboard_manager.js be the logical place to set this?
Amir,
Does e.me really find keyboard.current useful? If an English speaker in in San Francisco switches to a Chinese keyboard to send a text to a friend in Taiway, do you really want e.me results to change based on that transient keyboard change? What if the user forgets to switch their keyboard back to English and are then puzzled when e.me gives strange results?
Flags: needinfo?(dflanagan)
Assignee | ||
Comment 4•11 years ago
|
||
(In reply to David Flanagan [:djf] from comment #3)
> Does e.me really find keyboard.current useful? If an English speaker in in
> San Francisco switches to a Chinese keyboard to send a text to a friend in
> Taiway, do you really want e.me results to change based on that transient
> keyboard change? What if the user forgets to switch their keyboard back to
> English and are then puzzled when e.me gives strange results?
Keyboard.current is a very helpful hint for providing better results.
Some of the uses are:
1. autocomplete suggestions
2. spelling correction
3. stopwords identification
4. disambiguate words that are used in multiple languages
In your example, in case the user switches to Chinese keyboard and forgets to switch back, she would be searching in Chinese - so showing Chinese results would be suitable indeed.
Updated•11 years ago
|
Component: Gaia::Search → Gaia::Everything.me
Assignee | ||
Updated•10 years ago
|
Blocks: vertical-homescreen, collection-app
Summary: Send language, timezone and keyboard params to Everything.me Partners API → Send device information to Everything.me Partners API
Assignee | ||
Updated•10 years ago
|
User Story: (updated)
Assignee | ||
Comment 5•10 years ago
|
||
Attachment #8430041 -
Flags: review?(ran)
Assignee | ||
Comment 6•10 years ago
|
||
David, is |keyboard.current| deprecated in master? is there an alternative?
Flags: needinfo?(dflanagan)
Updated•10 years ago
|
blocking-b2g: --- → backlog
feature-b2g: --- → 2.0
Updated•10 years ago
|
Whiteboard: [systemsfe]
Updated•10 years ago
|
Target Milestone: --- → 2.0 S3 (6june)
Assignee | ||
Comment 7•10 years ago
|
||
Comment on attachment 8430041 [details]
PR
Please see comments on GH.
Attachment #8430041 -
Attachment description: PR [WIP] → PR
Attachment #8430041 -
Flags: feedback?(kgrandon)
Comment 8•10 years ago
|
||
Comment on attachment 8430041 [details]
PR
It's a bit hard to find the relevant parts due to a few extra commits in there. I think you should rebase against upstream master to get rid of the extra commits. Thanks!
Attachment #8430041 -
Flags: feedback?(kgrandon) → feedback+
Updated•10 years ago
|
Attachment #8430041 -
Flags: review?(ran) → review+
Assignee | ||
Comment 9•10 years ago
|
||
dropped keyboard.current and tracking carrier change:
https://github.com/EverythingMe/gaia/commit/7d743d89c1848bb0c4646cf7e910c2e160c90ebf
Flags: needinfo?(dflanagan)
Assignee | ||
Comment 10•10 years ago
|
||
:gandalf is using |language.current| from settings any different than |navigator.mozL10n.language.code| ?
Flags: needinfo?(gandalf)
Assignee | ||
Comment 11•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Comment 12•10 years ago
|
||
(In reply to Amir Nissim (Everything.me) from comment #10)
> :gandalf is using |language.current| from settings any different than
> |navigator.mozL10n.language.code| ?
It should not be, but if you want to observe language changes you should use the new API onlanguagechange+navigator.language instead.
Landed in bug 889335. In bug 1013929 we transitioned to use it in mozL10n. I'd recommend you transitioning away from mozSettings' language.current toward it.
Flags: needinfo?(gandalf)
Comment 13•10 years ago
|
||
Mass modify - set status-b2g-v2.0 fixed for fixed bugs under vertical homescreen dependency tree.
status-b2g-v2.0:
--- → fixed
Updated•10 years ago
|
blocking-b2g: backlog → ---
tracking-b2g:
--- → backlog
You need to log in
before you can comment on or make changes to this bug.
Description
•