Closed
Bug 961740
Opened 11 years ago
Closed 11 years ago
Highlighter outline not always visible
Categories
(DevTools :: Inspector, defect)
DevTools
Inspector
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 29
People
(Reporter: pbro, Assigned: pbro)
Details
(Whiteboard: [good first verify])
Attachments
(1 file)
(deleted),
patch
|
paul
:
review+
|
Details | Diff | Splinter Review |
STR:
- Open http://www.mozilla.org/en-US/
- Inspect the phrase "Doing good is part of our code"
- In the markup view, make sure the actual text node is expanded
- Hover over the <p> element, the highlighter should be display correctly
- Hover over the child text node, the highlighter should be hidden
- Hover again over the <p> element
==> Only the nodeinfo bar is shown
==> Expected: both the nodeinfo bar and the outline should be shown.
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → pbrosset
Assignee | ||
Comment 1•11 years ago
|
||
This is another small problem that appeared after bug 916443.
The change is really simple.
I added a new step in an existing test for this.
Ongoing try build: https://tbpl.mozilla.org/?tree=Try&rev=c05fe7f0f596
Attachment #8362555 -
Flags: review?(fayearthur)
Comment 2•11 years ago
|
||
Comment on attachment 8362555 [details] [diff] [review]
bug961740-always-show-highlighter-outline.patch
Stealing review...
Attachment #8362555 -
Flags: review?(fayearthur) → review+
Assignee | ||
Comment 3•11 years ago
|
||
Thanks Paul for the quick review. Try is happy too, so, I'm going to check this in.
Assignee | ||
Comment 4•11 years ago
|
||
Fixed in fx-team
https://hg.mozilla.org/integration/fx-team/rev/834e7d365f01
Whiteboard: [fixed-in-fx-team]
Comment 5•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 29
Updated•11 years ago
|
Whiteboard: [good first verify]
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•