Closed
Bug 962007
Opened 11 years ago
Closed 10 years ago
Accesskeys don't let you activate the click-to-play "Allow Now" and "Allow and Remember" buttons
Categories
(Firefox :: Keyboard Navigation, defect)
Firefox
Keyboard Navigation
Tracking
()
Tracking | Status | |
---|---|---|
firefox34 | --- | verified |
People
(Reporter: MarcoZ, Assigned: Gijs)
References
(Blocks 1 open bug)
Details
(Keywords: access, regression)
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
dao
:
review+
|
Details | Diff | Splinter Review |
Possible regression from bug 940040: When the doorhanger for Click-To-Play comes up, pressing *any*key, even just holding down the Alt key to then press a for "allow", will immediately dismiss the doorhanger. It is currently only possible to activate the buttons using the mouse.
Assignee | ||
Comment 1•11 years ago
|
||
This is on Windows, though? I was under the impression (which could be mistaken!) that bug 940040 only changed things on GTK (Linux/BSD/etc.) - Neil?
Flags: needinfo?(neil)
Comment 2•11 years ago
|
||
a) correct, 940040 only changed GTK-only code
b) I don't see this on Windows (self-build from 4 days ago)
Flags: needinfo?(neil)
Reporter | ||
Comment 3•11 years ago
|
||
This is on a nightly build dated 2014-01-19, and I only see it in Click to play, not with other doorhangers.
Updated•11 years ago
|
No longer blocks: 940040
Keywords: regressionwindow-wanted
Comment 4•11 years ago
|
||
(In reply to Marco Zehe (:MarcoZ) from comment #0)
> pressing *any*key, even just holding down the Alt key to then
> press a for "allow", will immediately dismiss the doorhanger.
only ALT+'A' dismisses the doorhanger pop-up for me
> It is currently only possible to activate the buttons using the mouse.
how did you trigger the CTP pop-up with the keyboard in the beginning ?
This is repro on FF 26, so I don't think it's a regression.
Blocks: click-to-play
Flags: needinfo?(marco.zehe)
Reporter | ||
Comment 5•11 years ago
|
||
(In reply to Paul Silaghi, QA [:pauly] from comment #4)
> only ALT+'A' dismisses the doorhanger pop-up for me
That's what I thought at first, too, but when I did it, the doorhanger was gone, but the plugin wasn't being activated.
> how did you trigger the CTP pop-up with the keyboard in the beginning ?
By pressing Space on the button that appears in the browser at the place where the plugin would appear. You should just be able to tab there and press Space. Note that I was using a screen reader.
However the results aren't consistent. After I filed this bug, I also noticed that sometimes, keyboard focus is moved to the doorhanger, and I can just tab once to the Allow button and press Space, which will then activate the plugin. I will keep watching out for odities here.
Flags: needinfo?(marco.zehe)
Reporter | ||
Comment 6•10 years ago
|
||
As per Gijs's request, NI'ing him on doorhanger-keyboard-accessibility-related bugs.
Flags: needinfo?(gijskruitbosch+bugs)
Assignee | ||
Comment 7•10 years ago
|
||
I can only get the "Allow Now" and "Allow and Remember" thing to show up, and access keys don't work there, but tab navigation does. From the preceding comments, it's not really clear to me that this is a regression, so I'm clearing the relevant keywords.
Actually, casual investigation suggests this is because the code sets accesskey properties, but they don't get put in the relevant attributes, potentially because the XBL of those buttons isn't hooked up at the point where it's being set. I can just have a look if fixing this the trivial way might just be enough here, leaving needinfo for that.
Blocks: doorhangersa11y
Flags: firefox-backlog+
Keywords: regression,
regressionwindow-wanted
Summary: Trying to manipulate the Click-To-Play doorhanger no longer works with the keyboard → Accesskeys don't let you activate the click-to-play "Allow Now" and "Allow and Remember" buttons
Assignee | ||
Comment 8•10 years ago
|
||
This was actually subtly visible before because the accesskeys weren't underlined (which surprised me, but didn't ring as many alarm bells as it should have). This fix is immediately verifiable because now the access keys are underlined and actually work! :-)
Attachment #8469320 -
Flags: review?(jaws)
Attachment #8469320 -
Flags: feedback?(marco.zehe)
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Assignee | ||
Comment 9•10 years ago
|
||
Gavin, I seem to have managed to divest bug 1036186 to peterv, and this was low-hanging fruit, so I picked this up - hope that's OK.
Iteration: --- → 34.2
Points: --- → 1
QA Whiteboard: [qa+]
Flags: needinfo?(gijskruitbosch+bugs) → needinfo?(gavin.sharp)
QA Contact: florin.mezei
Comment 10•10 years ago
|
||
Comment on attachment 8469320 [details] [diff] [review]
use attributes instead of properties to set accesskeys,
Please just replace .accesskey with .accessKey
Attachment #8469320 -
Flags: review?(jaws) → review-
Updated•10 years ago
|
Blocks: 880735
Keywords: regression
Assignee | ||
Comment 11•10 years ago
|
||
Attachment #8469382 -
Flags: review?(dao)
Assignee | ||
Updated•10 years ago
|
Attachment #8469320 -
Attachment is obsolete: true
Attachment #8469320 -
Flags: feedback?(marco.zehe)
Updated•10 years ago
|
Attachment #8469382 -
Flags: review?(dao) → review+
Updated•10 years ago
|
OS: Windows 7 → All
Hardware: x86_64 → All
Assignee | ||
Comment 13•10 years ago
|
||
w/ commit message adjusted (oops):
remote: https://hg.mozilla.org/integration/fx-team/rev/eef690f72166
Whiteboard: [fixed-in-fx-team]
Comment 14•10 years ago
|
||
Added to Iteration 34.2 since other work is blocked (1043372).
(In reply to :Gijs Kruitbosch from comment #9)
> Gavin, I seem to have managed to divest bug 1036186 to peterv, and this was
> low-hanging fruit, so I picked this up - hope that's OK.
Flags: needinfo?(gavin.sharp)
Comment 15•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 34
Comment 16•10 years ago
|
||
How can this be tested? I can activate the CTP doorhanger with the keyboard in a nightly before the fix too.
Flags: needinfo?(gijskruitbosch+bugs)
Assignee | ||
Comment 17•10 years ago
|
||
(In reply to Paul Silaghi, QA [:pauly] from comment #16)
> How can this be tested? I can activate the CTP doorhanger with the keyboard
> in a nightly before the fix too.
As the summary says, this is about the buttons not being accessible using access keys, not the general keyboard access with tabs, or of just opening the doorhanger. And as I noted in comment 8:
(In reply to :Gijs Kruitbosch from comment #8)
> Created attachment 8469320 [details] [diff] [review]
> use attributes instead of properties to set accesskeys,
>
> This was actually subtly visible before because the accesskeys weren't
> underlined (which surprised me, but didn't ring as many alarm bells as it
> should have). This fix is immediately verifiable because now the access keys
> are underlined and actually work! :-)
Flags: needinfo?(gijskruitbosch+bugs)
Comment 18•10 years ago
|
||
Ty Gijs.
How about Mac and Linux?
Nothing is underlined on Mac, the keys are underlined on Linux but don't work either.
Assignee | ||
Comment 19•10 years ago
|
||
(In reply to Paul Silaghi, QA [:pauly] from comment #18)
> Ty Gijs.
> How about Mac and Linux?
> Nothing is underlined on Mac, the keys are underlined on Linux but don't
> work either.
Mac doesn't use access keys the same way that Windows does, so this bug doesn't apply there. It should work on Linux, if the keys are underlined there. If it doesn't, that's probably a separate bug. You should be able to verify this on Windows.
Assignee | ||
Comment 20•10 years ago
|
||
(actually, the access keys seem to work fine for me on Linux... alt-r activates the "Allow and Remember" button as expected)
Comment 21•10 years ago
|
||
I see the popup dismissed too, but without any other effect (the video is not allowed to play)
Assignee | ||
Comment 22•10 years ago
|
||
(In reply to Paul Silaghi, QA [:pauly] from comment #21)
> I see the popup dismissed too, but without any other effect (the video is
> not allowed to play)
What build are you using? What page/settings are you using to test? And is this happening on both Windows and Linux?
Flags: needinfo?(paul.silaghi)
Comment 23•10 years ago
|
||
Works fine on Windows. Verified fixed 34.0a1 (2014-08-11), Win 7 x64
Updated•10 years ago
|
QA Whiteboard: [qa+] → [qa!]
QA Contact: florin.mezei → paul.silaghi
You need to log in
before you can comment on or make changes to this bug.
Description
•