Closed
Bug 962349
Opened 11 years ago
Closed 11 years ago
Enable snippets
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(firefox29 fixed, firefox30 affected)
RESOLVED
FIXED
Firefox 30
People
(Reporter: Margaret, Assigned: Margaret)
References
Details
Attachments
(1 file)
(deleted),
patch
|
bnicholson
:
review+
|
Details | Diff | Splinter Review |
Snippets are currently disabled by default, but the snippets JSON endpoint just went into production, so we should flip the switch!
Assignee | ||
Comment 1•11 years ago
|
||
Right now there are no snippets in production, so this won't have any user-visible effect. However, I did verify that with this pref flipped, we're getting a valid response from the snippets server, and caching an empty array in snippets.json.
Assignee: nobody → margaret.leibovic
Attachment #8363892 -
Flags: review?(bnicholson)
Comment 2•11 years ago
|
||
Comment on attachment 8363892 [details] [diff] [review]
patch
Review of attachment 8363892 [details] [diff] [review]:
-----------------------------------------------------------------
\o/
Attachment #8363892 -
Flags: review?(bnicholson) → review+
Assignee | ||
Comment 3•11 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/720e51754413
As I said above, there should be no user-visible effect now, but once there are live snippets targeting Nightly, users should start seeing them.
Comment 4•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 29
Comment 5•11 years ago
|
||
backed this out to try and diagnose some eideticker regressions:
https://hg.mozilla.org/integration/fx-team/rev/1a81ffef4464
Comment 6•11 years ago
|
||
Merge of backout:
https://hg.mozilla.org/mozilla-central/rev/1a81ffef4464
Note that this landed prior to the uplift, so it's still on Aurora29.
Status: RESOLVED → REOPENED
status-firefox29:
--- → fixed
status-firefox30:
--- → affected
Resolution: FIXED → ---
Target Milestone: Firefox 29 → ---
Assignee | ||
Comment 7•11 years ago
|
||
(In reply to Ryan VanderMeulen [:RyanVM UTC-5] from comment #6)
> Merge of backout:
> https://hg.mozilla.org/mozilla-central/rev/1a81ffef4464
>
> Note that this landed prior to the uplift, so it's still on Aurora29.
Thanks, Ryan. We're using this as a diagnostic tool, and hopefully if we figure out that this caused the regression, we'll try some more things to improve snippets performance, since we really do want to enable them for 29.
Assignee | ||
Comment 8•11 years ago
|
||
Re-landing with bug 964511:
https://hg.mozilla.org/integration/fx-team/rev/494ca694e768
Comment 9•11 years ago
|
||
Status: REOPENED → RESOLVED
Closed: 11 years ago → 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 30
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•