Closed
Bug 962355
Opened 11 years ago
Closed 11 years ago
Edge gestures do not work after selecting in task manager
Categories
(Firefox OS Graveyard :: Gaia, defect)
Tracking
(blocking-b2g:1.4+, b2g-v1.4 fixed)
Tracking | Status | |
---|---|---|
b2g-v1.4 | --- | fixed |
People
(Reporter: kgrandon, Assigned: aus)
References
Details
(Whiteboard: [systemsfe][mwcdemo2014][p=1])
Attachments
(2 obsolete files)
No description provided.
Reporter | ||
Comment 1•11 years ago
|
||
I'm assuming that moving the search screen into app window is the way to go here.
Reporter | ||
Comment 2•11 years ago
|
||
Reporter | ||
Comment 3•11 years ago
|
||
Summary: Edge gestures do not work after selecting in task manager → [IN ROCKETBAR] Edge gestures do not work after selecting in task manager
Updated•11 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → DUPLICATE
Whiteboard: DUPEME
Reporter | ||
Comment 6•11 years ago
|
||
I would like to leave this one open as I have landed a patch for it in the rocketbar branch, and plan to merge it to master. Feel free to dupe the other one against this. Both are assigned to me now.
Fix landed in: https://github.com/mozilla-b2g/gaia/commit/2232091855980dcf64bb0e640ac65876bfda6cd7
Status: RESOLVED → REOPENED
Resolution: DUPLICATE → ---
Updated•11 years ago
|
Blocks: edge-gestures
Reporter | ||
Comment 8•11 years ago
|
||
Comment on attachment 8363360 [details]
Github pull request Rocketbar branch
Etienne - Do you have any preferred approach?
This patch has landed in the rockebar branch, but if you could review it - I will update it and land in master as well. Thanks!
Attachment #8363360 -
Flags: review?(etienne)
Comment 9•11 years ago
|
||
Comment on attachment 8363360 [details]
Github pull request Rocketbar branch
Well the real issue is that we get a |homescreenopening| event when launching the cardview but no |launchapp| event when selecting an app. So no wonder why the EdgeSwipeDetector is lost :)
We should definitely fix this.
Fixing just the "enabling" part exposes the user to a world of bad state.
You can try this on the current rocketbar branch:
- open 2 apps, A then B
- swipe once from the left to get to A
- launch the rocketbar
- select B (the card order is wrong but that's another issue)
- try swiping from the left again to get to A
-> PAIN because the StackManager believes your current position is *already* A
So, while waiting for a StackManager based CardView, I think our best bet is to get a |launchapp| event dispatched when we launch an app from the CardView.
It will fix the "enabling" part and guarantee a consistent state since it will look like a round trip to the homescreen event-wise,
The only pitfall is that it will modify the order of the stack.
PS some notes on the patch itself:
* I don't think the |if (Rocketbar.shown)| is needed (and this way we prevent too much coupling between EdgeSwipeDetector and Rocketbar)
* The tests should be reworked to be more "external", just checking the outside effects (the |disabled| css class) instead of private vars.
PPS: that's a lot of information, ping me if anything is unclear :)
Attachment #8363360 -
Flags: review?(etienne) → review-
Reporter | ||
Comment 10•11 years ago
|
||
Final implementation will vary, so unblocking from bug 959353.
No longer blocks: 959353
Status: REOPENED → ASSIGNED
Summary: [IN ROCKETBAR] Edge gestures do not work after selecting in task manager → Edge gestures do not work after selecting in task manager
Reporter | ||
Comment 11•11 years ago
|
||
This may be a quick way to fix the state, it seems to be working fairly well for me. Unfortunately the cards view is not updated correctly. I'll look into this a bit more this/next week to see if there's anything we can do before cards view gets refactored.
Attachment #8363360 -
Attachment is obsolete: true
Updated•11 years ago
|
Whiteboard: [systemsfe]
Assignee | ||
Comment 12•11 years ago
|
||
Stealing this. Fix will land as part of bug 939809.
Assignee: kgrandon → aus
Depends on: 939809
Updated•11 years ago
|
Whiteboard: [systemsfe] → [systemsfe][mwcdemo2014]
Reporter | ||
Updated•11 years ago
|
Attachment #8367160 -
Attachment is obsolete: true
Assignee | ||
Comment 13•11 years ago
|
||
Fixed with landing of 939809.
Commit: https://github.com/mozilla-b2g/gaia/commit/91a572e0fb84a12e7499a718dd7e50192a62a442
Status: ASSIGNED → RESOLVED
Closed: 11 years ago → 11 years ago
Resolution: --- → FIXED
Updated•11 years ago
|
Target Milestone: --- → 1.4 S2 (28feb)
Updated•11 years ago
|
blocking-b2g: --- → 1.4+
Updated•11 years ago
|
Whiteboard: [systemsfe][mwcdemo2014] → [systemsfe][mwcdemo2014][p=1]
Updated•11 years ago
|
status-b2g-v1.4:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•