Closed Bug 962665 Opened 11 years ago Closed 7 years ago

Cmd + ' doesn't work for step over

Categories

(DevTools :: Debugger, defect, P3)

x86
macOS
defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: fitzgen, Unassigned, Mentored)

References

(Blocks 2 open bugs)

Details

(Whiteboard: [shortcuts][lang=js][lang=xul])

In bug 892277, we added both F10 and Cmd + ' to act as step over, however Cmd + ' isn't working for me in Nightly 29.

http://dxr.mozilla.org/mozilla-central/source/browser/locales/en-US/chrome/browser/devtools/debugger.dtd#190

STR:

1. Load mozilla.org

2. Open debugger

3. Set breakpoint on first line of Tabzilla constructor in tabzilla.js

4. Refresh and hit BP

5. Press Cmd + '

ER:

Step over to the next line

AR:

Nothing

Not sure if any of our other shortcuts added in that bug are also broken, but it is worth investigating.
Depends on: 892277
Whiteboard: [shortcuts]
takin' a look... love me some shortcuts...
Assignee: nobody → rcampbell
Status: NEW → ASSIGNED
I've taken a look and didn't see anything obvious. The command and keys seem to be wired up correctly.

Unassigning until I have some more time to figure out what's going on.
Assignee: rcampbell → nobody
Status: ASSIGNED → NEW
Whiteboard: [shortcuts] → [shortcuts][mentor=vporof][lang=js][lang=xul]
Priority: -- → P3
(In reply to Rob Campbell [:rc] (:robcee) from comment #3)
> I've taken a look and didn't see anything obvious. The command and keys seem
> to be wired up correctly.
> 
> Unassigning until I have some more time to figure out what's going on.

I'm curious if this shortcut is being eaten by the code editor as a default functionality. From what I see it (Ctrl + ') behaves the same as (ctrl + [) "highlight-brackets". Just another idea of where to look if anyone gets another chance to dig in.
Mentor: vporof
Whiteboard: [shortcuts][mentor=vporof][lang=js][lang=xul] → [shortcuts][lang=js][lang=xul]
F10 and Cmd + ' doesn't work in Nightly 34 also..

Thanks,
Jayesh
Summary: Cmd + ' not stepping over → Cmd + ' doesn't work for step over
Can confirm this doesn't work in FireFox 34 stable too, could I be assigned to this ticket please?
Feel free to start working on a patch, you don't need anyone's permission. Once you get something working reasonably well, attach the patch to the bug and ask for feedback, then the reviewer will assign the bug to you. Good luck!
This is fixed in the new debugger front end on Nightly.  Just tested.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Product: Firefox → DevTools
Blocks: 1565711
Blocks: 1565713
No longer blocks: 1565711
No longer blocks: 1565713
You need to log in before you can comment on or make changes to this bug.