Closed
Bug 962815
Opened 11 years ago
Closed 11 years ago
Dismissing pin site popup makes the pin button stay highlighted.
Categories
(Firefox for Metro Graveyard :: App Bar, defect, P2)
Tracking
(firefox28 verified, firefox29 verified)
VERIFIED
FIXED
Firefox 29
People
(Reporter: rsilveira, Assigned: emtwo)
References
Details
(Whiteboard: [release28] [defect] p=1)
Attachments
(1 file)
|
(deleted),
patch
|
rsilveira
:
review+
|
Details | Diff | Splinter Review |
STR:
1. Navigate to a site and click "pin to start" on nav bar
2. Dismiss the popup by clicking somewhere in content outside the popup
Expected:
Pin button goes back to initial 'unselected' state.
Actual:
Pin button is in 'selected' state giving the impression that the tile was created, even though it wasn't. It only creates when you click 'pin to start' on the popup. Clicking on it unselects.
|
||
Updated•11 years ago
|
Blocks: metrov1backlog
Whiteboard: [triage] [defect] p=0
|
|
||
Updated•11 years ago
|
Whiteboard: [triage] [defect] p=0 → [release28] [defect] p=0
|
|
||
Updated•11 years ago
|
Whiteboard: [release28] [defect] p=0 → [release28] [defect] p=1
|
Assignee | |
Updated•11 years ago
|
Assignee: nobody → msamuel
|
|
||
Updated•11 years ago
|
Status: NEW → ASSIGNED
Priority: -- → P2
QA Contact: jbecerra
|
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #8366671 -
Flags: review?(rsilveira)
|
Reporter | |
Comment 2•11 years ago
|
||
Comment on attachment 8366671 [details] [diff] [review]
v1: Update pin button after pin decision is made
Review of attachment 8366671 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good and works fine.
Attachment #8366671 -
Flags: review?(rsilveira) → review+
|
|
Assignee | |
Comment 3•11 years ago
|
||
Whiteboard: [release28] [defect] p=1 → [release28] [defect] [fixed-in-fx-team] p=1
|
||
Comment 4•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [release28] [defect] [fixed-in-fx-team] p=1 → [release28] [defect] p=1
Target Milestone: --- → Firefox 29
|
||
Comment 5•11 years ago
|
||
status-firefox28:
--- → fixed
status-firefox29:
--- → fixed
|
||
Comment 6•11 years ago
|
||
Verified as fixed on latest Aurora and latest Nightly with the STR from comment 0 using a Surface Pro 2 device.
You need to log in
before you can comment on or make changes to this bug.
Description
•