Closed
Bug 963041
Opened 11 years ago
Closed 11 years ago
Console API in workers should use the queueCall exposed by Console API webIDL
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
RESOLVED
FIXED
mozilla30
People
(Reporter: baku, Assigned: baku)
References
Details
Attachments
(1 file, 2 obsolete files)
|
(deleted),
patch
|
Details | Diff | Splinter Review |
This can be done only when bug 629607 is resolved.
|
Assignee | |
Comment 1•11 years ago
|
||
Of course this patch is meant to be applied on top of Console ported to WebIDL
Attachment #8364463 -
Flags: review?(bzbarsky)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 8364463 [details] [diff] [review]
consoleB.patch
Why do you need the ConsoleProxy? It used to be needed to cache the per-window JS object we created, but can't you just do wp->GetWindow()->Console() now?
|
|
Assignee | |
Comment 3•11 years ago
|
||
(In reply to Boris Zbarsky [:bz] from comment #2)
> Comment on attachment 8364463 [details] [diff] [review]
> consoleB.patch
>
> Why do you need the ConsoleProxy? It used to be needed to cache the
> per-window JS object we created, but can't you just do
> wp->GetWindow()->Console() now?
Right.
|
|
Assignee | |
Comment 4•11 years ago
|
||
Attachment #8364463 -
Attachment is obsolete: true
Attachment #8364463 -
Flags: review?(bzbarsky)
Attachment #8364508 -
Flags: review?(bzbarsky)
|
|
||
Comment 5•11 years ago
|
||
Comment on attachment 8364508 [details] [diff] [review]
consoleB.patch
>+ void queueCall(DOMString method, any arguments, optional any stack);
I don't see any reason for that last arg to be optional.
r=me with that nixed, thanks!
Attachment #8364508 -
Flags: review?(bzbarsky) → review+
|
|
Assignee | |
Comment 6•11 years ago
|
||
Attachment #8364508 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 7•11 years ago
|
||
Implemented in bug 965860
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
|
||
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•