Closed
Bug 963064
Opened 11 years ago
Closed 11 years ago
FileHandle cleanup
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla30
People
(Reporter: janv, Assigned: janv)
References
(Blocks 1 open bug)
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
bent.mozilla
:
review+
|
Details | Diff | Splinter Review |
- remove nsIDOMFileHandle interface
- remove DOMFileHandle.h/.cpp and change FileHandle.h/.cpp to provide a default FileHandle implementation
- related code style cleanup
|
Assignee | |
Updated•11 years ago
|
Attachment #8364312 -
Attachment is patch: true
Attachment #8364312 -
Flags: feedback?(Ms2ger)
|
|
Assignee | |
Comment 1•11 years ago
|
||
Assignee: nobody → Jan.Varga
Attachment #8364312 -
Attachment is obsolete: true
Attachment #8364312 -
Flags: feedback?(Ms2ger)
Attachment #8368501 -
Flags: review?(bent.mozilla)
|
|
Assignee | |
Comment 2•11 years ago
|
||
Comment on attachment 8368501 [details] [diff] [review]
rebased patch
Review of attachment 8368501 [details] [diff] [review]:
-----------------------------------------------------------------
Looks great, sorry this took so long!
::: dom/file/FileHandle.cpp
@@ +74,2 @@
>
> + nsRefPtr<FileHandle> newFileHandle(new FileHandle(aWindow));
Nit: Use = instead.
@@ +117,2 @@
> {
> + nsCOMPtr<nsIDOMFile> file =
Nit: whitespace
::: dom/file/FileHandle.h
@@ +87,3 @@
> virtual already_AddRefed<nsISupports>
> + CreateStream(nsIFile* aFile, bool aReadOnly);
> +
Nit: whitespace
Attachment #8368501 -
Flags: review?(bent.mozilla) → review+
|
|
Assignee | |
Comment 4•11 years ago
|
||
thanks, nits fixed
https://hg.mozilla.org/integration/mozilla-inbound/rev/90b514d09591
|
||
Comment 5•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
|
||
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•