grylchan Reporter
	Description • 23 years ago

Spun off from bug 86014

If you create a new mail profile, by default the 
Disk Space pref "Do not download messages locally larger than x kb"
is not checked. Yet when you try to download a folder with messages
> 50kb , they will not be downloaded.

I am assuming this is a back end issue and not a front end.
Since front end pref is remembered each time you check/uncheck
and/or change the message size limit.

If the pref is checked, it behaves as expected. messages are
not downloaded when it's greater than x kb. I can successfully
change the message size and it will adjust to the new download
size.

Steps to reproduce:
1.Create a brand new profile.
2.set up a imap mail account.
3.Go to Edit|Mail/News Account settings
4.Select Offline & Disk Space pref (for mail or newsgroup account)
5.Notice the checkbox is not marked for pref:
  "Do not download messages locally larger than 50 kb" 
6.Exit the preferences windows
7.Select a folder that has message(s) greater than 50kb.
8.Download that folder either with download now button or
  use the download and sync routine

Result: messages greater than 50kb are not downloaded
expected: all messages to be downloaded (including ones
          that are greater than 50kb) since I did
          not check this pref.

Note that this fix is needed for Imap, webmail, and newsgroups
accounts as this pref is in all of these accounts.

	Jack Angel
	Comment 1 • 23 years ago

Yeah, I have that bug too. Connected to internet, downloaded all messages,
disconnected - then look! 2 main big msgs aren't downloaded. Bad.

	(not reading, please use seth@sspitzer.org instead)
	Comment 3 • 23 years ago

Comment on attachment 48304 [details] [diff] [review]
proposed fix

sr=sspitzer

	David :Bienvenu Assignee
	Comment 4 • 23 years ago

this fix is attached to the wrong bug - I thought I'd attached this patch somewhere.

	David :Bienvenu Assignee
	Comment 6 • 23 years ago

FE was getting and setting the wrong pref/attribute.

	(not reading, please use seth@sspitzer.org instead)
	Comment 7 • 23 years ago

Comment on attachment 49129 [details] [diff] [review]
proposed fix

sr=sspitzer

	David :Bienvenu Assignee
	Comment 8 • 23 years ago

fix checked into trunk - nominating for branch.

	Scott MacGregor
	Comment 9 • 23 years ago

another low risk offline fix we want on the branch.

	grega
	Comment 10 • 23 years ago

We want this one.  Please check into the branch.  Marking PDT+

	Scott MacGregor
	Comment 11 • 23 years ago

PDT+ per PDT meeting today. Gary has signed off to do the QA on the branch.

	Scott MacGregor
	Comment 12 • 23 years ago

I checked this into the branch for david b. 

	grylchan Reporter
	Comment 13 • 23 years ago

Commercial branch builds
 2001-09-19-05-0.9.4/ win nt 4.0
 2001-09-19-04-0.9.4/ linux 2.2
 2001-09-19-08-0.9.4/ mac 9.1

Verified on imap and webmail that when pref 
"Do not download messages locally larger than x kb"
is not checked, the user can download any sized message
in any folder. If it is checked, then only messages
that are less than size specified will get downloaded.

Newsgroups isn't working correctly but I will file a
new bug on that, assume its the same problem as it
was for mail.

Adding keyword vtrunk

	grylchan Reporter
	Comment 14 • 23 years ago

commercial trunk
2001-10-08-09-trunk NT 4.0
2001-10-08-08-trunk linux 2.2
2001-10-08-08-trunk mac 9.1

Verified when pref 'do not download messages locally larger than x kb'
 -is checked : only messages less than x kb are downloaded
 -is not checked : all different sized messages are downloaded

marking as verified
removing key word vtrunk