Closed Bug 96335 Opened 23 years ago Closed 23 years ago

offline:Disk Space pref "Do not download messages locally larger than x kb" is invoked even if the pref is not set

Categories

(SeaMonkey :: MailNews: Backend, defect)

defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED
mozilla0.9.5

People

(Reporter: grylchan, Assigned: Bienvenu)

References

Details

(Whiteboard: PDT+)

Attachments

(1 file, 1 obsolete file)

Spun off from bug 86014 If you create a new mail profile, by default the Disk Space pref "Do not download messages locally larger than x kb" is not checked. Yet when you try to download a folder with messages > 50kb , they will not be downloaded. I am assuming this is a back end issue and not a front end. Since front end pref is remembered each time you check/uncheck and/or change the message size limit. If the pref is checked, it behaves as expected. messages are not downloaded when it's greater than x kb. I can successfully change the message size and it will adjust to the new download size. Steps to reproduce: 1.Create a brand new profile. 2.set up a imap mail account. 3.Go to Edit|Mail/News Account settings 4.Select Offline & Disk Space pref (for mail or newsgroup account) 5.Notice the checkbox is not marked for pref: "Do not download messages locally larger than 50 kb" 6.Exit the preferences windows 7.Select a folder that has message(s) greater than 50kb. 8.Download that folder either with download now button or use the download and sync routine Result: messages greater than 50kb are not downloaded expected: all messages to be downloaded (including ones that are greater than 50kb) since I did not check this pref. Note that this fix is needed for Imap, webmail, and newsgroups accounts as this pref is in all of these accounts.
Yeah, I have that bug too. Connected to internet, downloaded all messages, disconnected - then look! 2 main big msgs aren't downloaded. Bad.
Attached patch proposed fix (obsolete) (deleted) — Splinter Review
Comment on attachment 48304 [details] [diff] [review] proposed fix sr=sspitzer
Attachment #48304 - Flags: superreview+
this fix is attached to the wrong bug - I thought I'd attached this patch somewhere.
Attachment #48304 - Attachment is obsolete: true
Attachment #48304 - Flags: superreview+
Attached patch proposed fix (deleted) — Splinter Review
FE was getting and setting the wrong pref/attribute.
Comment on attachment 49129 [details] [diff] [review] proposed fix sr=sspitzer
Attachment #49129 - Flags: superreview+
fix checked into trunk - nominating for branch.
Status: NEW → ASSIGNED
Keywords: nsbranch
another low risk offline fix we want on the branch.
Keywords: nsbranchnsbranch+
Target Milestone: --- → mozilla0.9.5
Blocks: 99230
Blocks: 99508
We want this one. Please check into the branch. Marking PDT+
Whiteboard: PDT+
PDT+ per PDT meeting today. Gary has signed off to do the QA on the branch.
I checked this into the branch for david b.
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Commercial branch builds 2001-09-19-05-0.9.4/ win nt 4.0 2001-09-19-04-0.9.4/ linux 2.2 2001-09-19-08-0.9.4/ mac 9.1 Verified on imap and webmail that when pref "Do not download messages locally larger than x kb" is not checked, the user can download any sized message in any folder. If it is checked, then only messages that are less than size specified will get downloaded. Newsgroups isn't working correctly but I will file a new bug on that, assume its the same problem as it was for mail. Adding keyword vtrunk
Keywords: vtrunk
commercial trunk 2001-10-08-09-trunk NT 4.0 2001-10-08-08-trunk linux 2.2 2001-10-08-08-trunk mac 9.1 Verified when pref 'do not download messages locally larger than x kb' -is checked : only messages less than x kb are downloaded -is not checked : all different sized messages are downloaded marking as verified removing key word vtrunk
Status: RESOLVED → VERIFIED
Keywords: vtrunk
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: