Open
Bug 963780
Opened 11 years ago
Updated 2 years ago
Refactor TelemetryImpl::GetChromeHangs to never return a partial result
Categories
(Core :: General, defect)
Core
General
Tracking
()
NEW
People
(Reporter: vladan, Unassigned)
References
Details
(In reply to Nathan Froyd (:froydnj) from comment #4)
> Comment on attachment 8362720 [details] [diff] [review]
> chromehangsUptime.patch
>
> Review of attachment 8362720 [details] [diff] [review]:
> -----------------------------------------------------------------
>
> r=me with a good answer for the HangMonitor.cpp bit.
>
> ::: toolkit/components/telemetry/Telemetry.cpp
> @@ +1531,5 @@
> > }
> >
> > + ok = JS_DefineProperty(cx, fullReportObj, "systemUptime",
> > + OBJECT_TO_JSVAL(systemUptimeArray),
> > + nullptr, nullptr, JSPROP_ENUMERATE);
>
> Can you file a followup for inverting the order that we do things in this
> function, so that we:
>
> - build the arrays;
> - set fullReportObj properties;
> - set *ret.
>
> in that order? We've tried to not leave partial bits hanging around on
> failure in other reports; it'd be good to follow the same pattern here.
|
Reporter | |
Updated•11 years ago
|
Product: Chat Core → Core
Version: trunk → Trunk
|
||
Updated•2 years ago
|
Severity: normal → S3
You need to log in
before you can comment on or make changes to this bug.
Description
•