Closed
Bug 963913
Opened 11 years ago
Closed 11 years ago
Add doorhangers for signon.overrideAutocomplete
Categories
(Toolkit :: Password Manager, enhancement)
Toolkit
Password Manager
Tracking
()
RESOLVED
WONTFIX
People
(Reporter: manishearth, Assigned: manishearth)
Details
Attachments
(1 file, 2 obsolete files)
(deleted),
text/html
|
Details |
Bug 425145 implements a preference that allows the user to override `autocomplete=off`
Bug 956906 asks for the preference to be turned on by default.
As per Justin's comment on bug 425145 comment 53, Firefox supports doorhangers -- non-modal notifications that turn up on the location bar and can be addressed if the user feels like it.
We probably can add a doorhanger for this feature, too, if autocomplete is being overridden, and the page uses autocomplete=true, then display a doorhanger that says something like "This website wished to block form autofill, however your preferences overrode that. Do you wish for this behavior to continue?" or similar.
Assignee | ||
Updated•11 years ago
|
Component: Security → Password Manager
Product: Firefox → Toolkit
Summary: Add doorhangers for signong.overrrideAutocomplete → Add doorhangers for signon.overrrideAutocomplete
Comment hidden (obsolete) |
Assignee | ||
Updated•11 years ago
|
Attachment #8365517 -
Attachment mime type: text/plain → text/html
Comment hidden (obsolete) |
Assignee | ||
Updated•11 years ago
|
Attachment #8365519 -
Attachment mime type: text/plain → text/html
Assignee | ||
Comment 3•11 years ago
|
||
Attachment #8365519 -
Attachment is obsolete: true
Assignee | ||
Updated•11 years ago
|
Attachment #8365520 -
Attachment mime type: text/plain → text/html
Assignee | ||
Comment 4•11 years ago
|
||
Realized a little hitch: The password manager is in the toolkit, and the toolkit doesn't seem to have access to the browser variable since it's ... well ... the toolkit. (PupupNotifications requires[1] gBrowser)
Any idea how I could add some code here that will run *if* there is a browser, and where would I get access to the browser variable in that case?
I could possibly add code for this in a small module under /browser, and import it here. Not sure how to go about that though.
[1]: https://developer.mozilla.org/en-US/docs/Using_popup_notifications
Comment 5•11 years ago
|
||
WAG: Send out an observer notification from toolkit, identifying the content page with autocomplete=off. Then it's up to an observer in the front-end UI on how to handle the notification.
Assignee | ||
Comment 6•11 years ago
|
||
(In reply to Philip Chee from comment #5)
> WAG: Send out an observer notification from toolkit, identifying the content
> page with autocomplete=off. Then it's up to an observer in the front-end UI
> on how to handle the notification.
Thanks, this works well :D
If this is implemented we'll need a "learn more" page for it, like this one: https://support.mozilla.org/en-US/kb/how-does-content-isnt-secure-affect-my-safety?as=u&utm_source=inproduct
Assignee | ||
Comment 7•11 years ago
|
||
I just realized that there are a bunch of different doorhangers that we can support:
- When submitting a form with autocomplete on without the override, have a popup doorhanger that asks "This page has disabled password saving, do you still wish to save the password"?, with the options:
- No
- No, and don't show this message again
- Yes
- Do not allow websites to disable password saving
- Not Now
- When submitting a form with autocomplete on *with* the override, have a non-popup doorhanger (dismissed:true) that asks "This page wished to disable password saving, however your preferences overrode that"
- Continue to override
- Stop overriding
- Not Now
(The wording could be improved)
Needinfo'ing Justin since it was initially his idea.
Also, if someone could make icons for this it would be great.
Flags: needinfo?(dolske)
Assignee | ||
Updated•11 years ago
|
Summary: Add doorhangers for signon.overrrideAutocomplete → Add doorhangers for signon.overrideAutocomplete
Comment 8•11 years ago
|
||
This seems like overkill/potentially annoying. IMO we should fix bug 956906 (or some form of it - possibly just the "save password" part).
Comment 9•11 years ago
|
||
Yeah. We should either ignore the attribute entirely (956906), or treat it as a cue to prompt to fill the page manually. (Don't have the bug # handy, but it's been a long-standing security quest to have a way to disable automatic formfill, and instead have a "do you want to log in on this page [yes] [no]" kind of prompt. If we had that, automatic formfill + autocomplete=off could use it.)
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Flags: needinfo?(dolske)
Resolution: --- → WONTFIX
Assignee | ||
Comment 10•11 years ago
|
||
(In reply to Justin Dolske [:Dolske] from comment #9)
> and instead have a "do you want to log in on this page
> [yes] [no]" kind of prompt.
Yeah, that would work, and probably can be implemented via doorhangers again :)
If you find that bug, let me know, I might work on it.
You need to log in
before you can comment on or make changes to this bug.
Description
•