Closed Bug 964064 Opened 11 years ago Closed 11 years ago

ShortcutUtils.jsm should capitalize shortcut keys

Categories

(Toolkit :: General, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla29

People

(Reporter: Gijs, Assigned: Gijs)

References

Details

Attachments

(1 file)

Right now, if the shortcut key is defined as lowercase, we return it as such. Convention in every OS we ship on is uppercase. The module should probably deal with that itself. Patch coming up soon. NB: slight worry: what does .toUpperCase() do for e.g. non-Latin-based scripts, and what is convention there?
Random spot-check seems to indicate this should generally produce the desired result. However, see also: http://stackoverflow.com/questions/19286435/javascript-touppercase-mess-up-in-chrome-for-latin-character . An alternative solution would be WONTFIX, and making l10n teams update their strings to uppercase where required.
Attachment #8365679 - Flags: review?(bmcbride)
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Attachment #8365679 - Flags: review?(bmcbride) → review+
Whiteboard: [fixed-in-fx-team]
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → mozilla29
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: