Closed
Bug 964194
Opened 11 years ago
Closed 10 years ago
B2G NFC: remove NFCTag.getDetailsNDEF()
Categories
(Firefox OS Graveyard :: NFC, defect)
Tracking
(tracking-b2g:backlog)
People
(Reporter: allstars.chh, Assigned: allstars.chh)
References
Details
Attachments
(1 file)
(deleted),
patch
|
dimi
:
review+
smaug
:
review+
|
Details | Diff | Splinter Review |
This is mentioned by Jonas.
Are "DetailsNDEF"alreay ready when chrom sends out 'techDiscovered' system message? If so, then we should have those details contained in the 'techDiscovered' system message rather than exposing getDetailsNDEF().
Also Hsinyi mentioned maybe we could make those data as attributes in NFCTag.
Blocks: 948721
I think we should keep the getDetailsNDEF function if it triggers another radio roundtrip. But if we are getting the details in the radio communication we're already doing, then we might as well include them there.
Updated•11 years ago
|
Blocks: b2g-NFC-2.0
Updated•11 years ago
|
No longer blocks: b2g-NFC-2.0
Comment 2•11 years ago
|
||
Things like "this tag type is read only, and 512 bytes in size" might be quite useful to NFC Tag application developers (it might possibly change if the tag type is changed).
There's some plans to add NDEFTag, MiFareTag, ISODepTag. So what we probably need <Tag Object Parent>.getDetails() in say, NFCTag instead if we keep it.
See: Bug 916428 (ISODep) for some ideas on that interface.
Updated•11 years ago
|
blocking-b2g: --- → backlog
Assignee | ||
Updated•10 years ago
|
Blocks: b2g-nfc-privilege
Assignee | ||
Comment 3•10 years ago
|
||
Since the result of this API are also available when tag is discovered,
So we will remove this method and will add another methods 'getMaxNDEFLength', 'isReadOnly', 'canBeMadeReadonly'.
Assignee: nobody → allstars.chh
Summary: B2G NFC: Do we need NFCTag.getDetailsNDEF()? → B2G NFC: remove NFCTag.getDetailsNDEF()
Assignee | ||
Comment 4•10 years ago
|
||
Attachment #8477277 -
Flags: review?(dlee)
Updated•10 years ago
|
Attachment #8477277 -
Flags: review?(dlee) → review+
Assignee | ||
Comment 5•10 years ago
|
||
Comment on attachment 8477277 [details] [diff] [review]
Patch
Hi Smaug
This interface getDetailsNDEF will retrieve the following information of the NFCTag from nfc daemon:
- Max NDEF length
- Is this tag readonly?
- Can this tag be made to readonly?
However getDetails is too verbose and we're going to split this to more attributes (or a getter method) to make it more easier to understand.
Like
maxNDEFLength, isReadOnly, ... etc
Also NFC Research Lab Hagenberg has sent a similar feedback to W3C NFC API. [1]
So we propose to remove this API for now.
We will file another bugs to discuss to add those attributes in our NFC API later because it needs some modification in our nfcd side, which is still under discussion now.
Can you help to review this for us?
Thanks
[1]: http://lists.w3.org/Archives/Public/public-nfc/2014Jan/0016.html
Attachment #8477277 -
Flags: review?(bugs)
Comment 6•10 years ago
|
||
Comment on attachment 8477277 [details] [diff] [review]
Patch
We have still ._nfcContentHelper.getDetailsNDEF and all the stuff.
Do we need all that?
Attachment #8477277 -
Flags: review?(bugs) → review+
Assignee | ||
Comment 7•10 years ago
|
||
Hi, Smaug
Sorry for not being clear, like Bug 963541 we plan to remove this first from WebIDL, however we are still in-discussion that whether we should keep the oringinal impl or totally rewrite them. :P
Assignee | ||
Comment 8•10 years ago
|
||
add checkin-needed for b2g-inbound is close
Depends on: 963541
Keywords: checkin-needed
Comment 9•10 years ago
|
||
Keywords: checkin-needed
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.1 S3 (29aug)
Assignee | ||
Updated•10 years ago
|
No longer blocks: b2g-nfc-privilege
Assignee | ||
Updated•10 years ago
|
Blocks: b2g-nfc-privilege
Updated•10 years ago
|
blocking-b2g: backlog → ---
tracking-b2g:
--- → backlog
You need to log in
before you can comment on or make changes to this bug.
Description
•