Closed
Bug 964209
Opened 11 years ago
Closed 11 years ago
[RTSP] Content process crash after bug 959861
Categories
(Core :: Audio/Video, defect, P1)
Tracking
()
People
(Reporter: bechen, Assigned: bechen)
References
Details
(Keywords: crash, regression, Whiteboard: [b2g-crash])
Attachments
(1 file, 2 obsolete files)
(deleted),
patch
|
bechen
:
review+
|
Details | Diff | Splinter Review |
http://hg.mozilla.org/mozilla-central/diff/b68184d3213d/content/media/omx/MediaOmxReader.cpp
RtspOmxReader override the |InitOmxDecoder|, but not set the |mExtractor| added by bug 959861.
Comment 1•11 years ago
|
||
Can we get a crash stack with this? What end user STR reproduces this bug?
Updated•11 years ago
|
Component: General → Video/Audio
Product: Firefox OS → Core
Updated•11 years ago
|
Assignee: nobody → bechen
Comment 2•11 years ago
|
||
Hi Jason, this bug happens when the user opens any RTSP streaming.
Fortunately, this bug is only in mozilla-central, which means we don't have this issue in FFOS v1.3.
And we already identified the root cause. Benjamin Chen is working on this. :)
Comment 3•11 years ago
|
||
(In reply to Ethan Tseng [:ethan] from comment #2)
> Hi Jason, this bug happens when the user opens any RTSP streaming.
> Fortunately, this bug is only in mozilla-central, which means we don't have
> this issue in FFOS v1.3.
> And we already identified the root cause. Benjamin Chen is working on this.
> :)
Sounds like a serious regression then.
blocking-b2g: --- → 1.4?
Keywords: regression
Assignee | ||
Comment 4•11 years ago
|
||
Attachment #8366501 -
Flags: review?(sworkman)
Comment 5•11 years ago
|
||
Comment on attachment 8366501 [details] [diff] [review]
bug-964209.patch
Review of attachment 8366501 [details] [diff] [review]:
-----------------------------------------------------------------
Looks fine to me. Please verify that there are no other cases of mExtractor not being set. r=me.
Attachment #8366501 -
Flags: review?(sworkman) → review+
Assignee | ||
Comment 6•11 years ago
|
||
r=sworkman
try server:
https://tbpl.mozilla.org/?tree=Try&rev=1247ada429d3
Attachment #8367167 -
Flags: review+
Updated•11 years ago
|
Attachment #8366501 -
Attachment is obsolete: true
Updated•11 years ago
|
Updated•11 years ago
|
Priority: -- → P1
Assignee | ||
Comment 8•11 years ago
|
||
Attachment #8367167 -
Attachment is obsolete: true
Attachment #8373102 -
Flags: review+
Assignee | ||
Updated•11 years ago
|
Keywords: checkin-needed
Comment 9•11 years ago
|
||
Keywords: checkin-needed
Comment 10•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
Updated•11 years ago
|
status-b2g-v1.4:
--- → fixed
status-firefox28:
--- → wontfix
status-firefox29:
--- → wontfix
status-firefox30:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•