Closed
Bug 964225
Opened 11 years ago
Closed 10 years ago
Remove the GB2312 and GBK decoders
Categories
(Core :: Internationalization, defect, P4)
Core
Internationalization
Tracking
()
RESOLVED
FIXED
mozilla35
People
(Reporter: hsivonen, Assigned: hsivonen)
References
Details
Attachments
(2 files)
(deleted),
patch
|
emk
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
emk
:
review+
|
Details | Diff | Splinter Review |
If bug 959058 sticks in the tree to release, remove the GB2312 and GBK decoders that became dead code.
Updated•11 years ago
|
Priority: -- → P4
Assignee | ||
Comment 1•11 years ago
|
||
When fixing this, also remove the strings gbk, gbk.key and gb18030 from charsetMenu.properties.
Assignee | ||
Updated•11 years ago
|
Status: NEW → ASSIGNED
QA Contact: hsivonen
Assignee | ||
Comment 2•10 years ago
|
||
Assignee: nobody → hsivonen
Assignee | ||
Updated•10 years ago
|
QA Contact: hsivonen
Assignee | ||
Updated•10 years ago
|
Attachment #8493646 -
Flags: review?(VYV03354)
Updated•10 years ago
|
Attachment #8493646 -
Flags: review?(VYV03354) → review+
Assignee | ||
Comment 3•10 years ago
|
||
Comment 4•10 years ago
|
||
Whole push reverted due to the OS X bustage in:
https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=932a92a16c29&jobname=osx.*debug
remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/c2d07802d0f4
remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/81ef2b9b375b
remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/a30b95df07ef
Assignee | ||
Comment 5•10 years ago
|
||
Oops. I failed to update the gfx code for processing legacy Mac Chinese font names and running only linux64 builds on try didn't catch that. Here's an addendum to do that.
https://tbpl.mozilla.org/?tree=Try&rev=a2c56adf562c
Note that names in WAP code and nsSearchService go through label-to-encoding handling, so it's not critical to update those, and those have more no-longer-canonical names around than just GB2312. I'll file bugs to update those.
Attachment #8496756 -
Flags: review?(VYV03354)
Updated•10 years ago
|
Attachment #8496756 -
Flags: review?(VYV03354) → review+
Assignee | ||
Comment 6•10 years ago
|
||
Comment 7•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/e538372b2413
https://hg.mozilla.org/mozilla-central/rev/529d26ff3f59
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
You need to log in
before you can comment on or make changes to this bug.
Description
•