Closed
Bug 964892
Opened 11 years ago
Closed 11 years ago
./WorkerConsoleBinding.cpp:715:24: error: too many arguments provided to function-like macro invocation (clang -stdlib=libc++)
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
RESOLVED
FIXED
mozilla29
People
(Reporter: jbeich, Assigned: baku)
References
Details
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
Details | Diff | Splinter Review |
On libc++ platforms <algorithm> pulls <assert.h> which may lead to a name conflict like
In file included from dom/bindings/UnifiedBindings31.cpp:146:
./WorkerConsoleBinding.cpp:715:24: error: too many arguments provided to
function-like macro invocation
_assert(JSContext* cx, JS::Handle<JSObject*> obj, mozilla::dom::workers::Wor...
^
/usr/include/assert.h:50:9: note: macro '_assert' defined here
#define _assert(e) ((void)0)
^
http://buildbot.rhaalovely.net/builders/mozilla-central-freebsd-amd64/builds/224/steps/build/logs/stdio
http://bxr.su/search?defs=_assert
with the following header chain
assert.h
cassert
memory
algorithm
nsRect.h or mozilla/BaseRect.h
Units.h
mozilla/BasicEvents.h
nsEventListenerManager.h
nsDOMEventTargetHelper.h
WorkerPrivate.h
Adding |#undef _assert| after the includes in WorkerConsoleBinding.cpp does help but I'm not familiar with WebIDL machinery to create a patch.
Assignee: nobody → amarchesini
Comment 2•11 years ago
|
||
Comment on attachment 8366849 [details] [diff] [review]
assert.patch
r=me, but may be worth a comment about why we need the trailing '_'.
Attachment #8366849 -
Flags: review?(bzbarsky) → review+
Assignee | ||
Comment 3•11 years ago
|
||
Attachment #8366849 -
Attachment is obsolete: true
Assignee | ||
Updated•11 years ago
|
Keywords: checkin-needed
Comment 4•11 years ago
|
||
Keywords: checkin-needed
Comment 5•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•