Closed
Bug 965250
Opened 11 years ago
Closed 11 years ago
Fix TextureHostD3D9
Categories
(Core :: Graphics: Layers, defect)
Tracking
()
RESOLVED
FIXED
mozilla29
People
(Reporter: nical, Assigned: nical)
References
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
bas.schouten
:
review+
|
Details | Diff | Splinter Review |
The new TextureHostD3D9 isn't properly copying the texture sent from the client.
|
Assignee | |
Comment 1•11 years ago
|
||
Assignee: nobody → nical.bugzilla
Attachment #8367297 -
Flags: review?(bas)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 8367297 [details] [diff] [review]
Fix TextureHostD3D9
Review of attachment 8367297 [details] [diff] [review]:
-----------------------------------------------------------------
::: gfx/layers/d3d9/TextureD3D9.cpp
@@ -1537,5 @@
> mSize.height = desc.Height;
> }
> }
>
> -TextureHostD3D9::TextureHostD3D9(TextureFlags aFlags)
Why are we removing this constructor? That isn't clear to me.
::: gfx/layers/d3d9/TextureD3D9.h
@@ +355,5 @@
> TextureHostD3D9(TextureFlags aFlags);
> IDirect3DDevice9* GetDevice();
>
> RefPtr<DataTextureSourceD3D9> mTextureSource;
> + IDirect3DTexture9* mTexture;
This can't possible be good....
Attachment #8367297 -
Flags: review?(bas) → review-
|
|
Assignee | |
Comment 3•11 years ago
|
||
Attachment #8367297 -
Attachment is obsolete: true
Attachment #8367326 -
Flags: review?(bas)
|
|
||
Updated•11 years ago
|
Attachment #8367326 -
Flags: review?(bas) → review+
|
|
Assignee | |
Comment 4•11 years ago
|
||
|
||
Comment 5•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
You need to log in
before you can comment on or make changes to this bug.
Description
•