Closed
Bug 965318
Opened 11 years ago
Closed 11 years ago
unxfail test_cost_control_reset_wifi on v1.3 when bug 965305 is fixed
Categories
(Firefox OS Graveyard :: Gaia::UI Tests, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: bsilverberg, Unassigned)
References
Details
Attachments
(1 file, 1 obsolete file)
After bug # 965305 is fixed, unxfail the test.
Reporter | ||
Updated•11 years ago
|
Attachment #8367369 -
Attachment is obsolete: true
Reporter | ||
Comment 1•11 years ago
|
||
Oops, that attachment above shouldn't have been there. I've obsoleted it.
This bug is just a placeholder/reminder to unxfail the test when we can.
Comment 3•11 years ago
|
||
The bug was fixed, but the test still fails on CI and locally.
Maybe the patch was not uplifted yet
Comment 4•11 years ago
|
||
I added an attachement but, let's wait for it to be Unexpected pass on CI
Attachment #8377072 -
Flags: review?(florin.strugariu)
Attachment #8377072 -
Flags: review?(bob.silverberg)
Comment 5•11 years ago
|
||
Comment on attachment 8377072 [details]
PR https://github.com/mozilla-b2g/gaia/pull/16362
the code looks OK
Let's see the new build
Attachment #8377072 -
Flags: review?(florin.strugariu) → review+
Comment 6•11 years ago
|
||
The fix was now uplifted to v1.3
https://hg.mozilla.org/releases/mozilla-b2g28_v1_3/rev/83d4288720dd
Bebe r?
Updated•11 years ago
|
Attachment #8377072 -
Flags: review+ → review?(florin.strugariu)
Updated•11 years ago
|
Attachment #8377072 -
Flags: review?(florin.strugariu) → review+
Reporter | ||
Comment 7•11 years ago
|
||
Comment on attachment 8377072 [details]
PR https://github.com/mozilla-b2g/gaia/pull/16362
The bug does not seem to be fixed as 2/2 tests that I ran on my Inari with the latest v1.3 failed with data usage still shown after resetting.
Are you not getting failures on Hamachis? Do you have a run of many tests with all passing?
If you can reproduce my failure I suggest you reopen Bug 965305 as it does not seem to be fixed.
Attachment #8377072 -
Flags: review?(bob.silverberg) → review-
Comment 8•11 years ago
|
||
Bob we only ran them on Hamachis and the test is currently Unexpected Passed on Jenkins for some time now. (since the fix was pushed to v1.3).
If you see the test failing on Inari you should reopen the bug stating the reason.
Comment 9•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•