Per yesterday's discussion with rfeeley, gruen, mnovak, and ibarlow.

This landed r=me; there's no review possible, since it rewrites every single string.

flod, pike: sorry to change so many strings. I changed essentially all string names, which will cost localizers some duplicate work, but I'm not worried about accidentally not renaming a changed string. I'm alerting you to the commit above in case something is seriously wrong, so that we have a hope of catching it before it hits mozilla-central. Thanks for your patience; this has been a tough process. 70 strings in one landing!

+<!ENTITY fxaccount_link_tos 'https://accounts.firefox.com/legal/terms'> +<!ENTITY fxaccount_link_pn 'https://accounts.firefox.com/legal/privacy'> +<!ENTITY fxaccount_getting_started_link_old_firefox 'https://support.mozilla.org/kb/use-sync-with-an-older-version-of-firefox'> <!ENTITY fxaccount_link_create_not_allowed 'http://www.ftc.gov/news-events/media-resources/protecting-consumer-privacy/kids-privacy-coppa'> We don't need to expose these links to localizers. +<!ENTITY fxaccount_create_account_unknown_error 'Could not create account'> +<!ENTITY fxaccount_account_create_not_allowed 'Cannot create account'> Not really l10n, but you may want better consistency here. In general a mix of "could not" and "cannot" in several places. +<!-- Note to translators: the format string below will be replaced + with the Firefox Account's email address. --> +<!ENTITY fxaccount_sync_sign_in_error_notification_text 'Tap to sign in to &formatS;'> format string will be replaced -> &formatS; will be replaced You don't need the l10n comment in strings.xml.in anymore.

(In reply to Francesco Lodolo [:flod] from comment #4) > +<!ENTITY fxaccount_link_tos 'https://accounts.firefox.com/legal/terms'> > +<!ENTITY fxaccount_link_pn 'https://accounts.firefox.com/legal/privacy'> > +<!ENTITY fxaccount_getting_started_link_old_firefox > 'https://support.mozilla.org/kb/use-sync-with-an-older-version-of-firefox'> > <!ENTITY fxaccount_link_create_not_allowed > 'http://www.ftc.gov/news-events/media-resources/protecting-consumer-privacy/ > kids-privacy-coppa'> > > We don't need to expose these links to localizers. OK, I'll move these to strings.xml.in. > +<!ENTITY fxaccount_create_account_unknown_error 'Could not create account'> > +<!ENTITY fxaccount_account_create_not_allowed 'Cannot create account'> > > Not really l10n, but you may want better consistency here. In general a mix > of "could not" and "cannot" in several places. These are actually different screens, but yes, we might want better consistency. We're planning a final UX sign-off pass; I'll raise this then. > +<!-- Note to translators: the format string below will be replaced > + with the Firefox Account's email address. --> > +<!ENTITY fxaccount_sync_sign_in_error_notification_text 'Tap to sign in to > &formatS;'> > > format string will be replaced -> &formatS; will be replaced > > You don't need the l10n comment in strings.xml.in anymore. Right-o, I was removing them as I went and must have missed some. flod, thanks so much for your guidance and patience. You've really helped me through this process and I appreciate it.