Closed Bug 965423 Opened 11 years ago Closed 10 years ago

[Madai][Camera][Gecko] Expose HDR settings

Categories

(Firefox OS Graveyard :: Gaia::Camera, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED DUPLICATE of bug 990761

People

(Reporter: mikeh, Assigned: youngwoo.jo)

References

Details

Expose high-dynamic range[1] settings to JS: - capability-supported attribute - enabled/disabled attribute 1. http://en.wikipedia.org/wiki/High-dynamic-range_imaging
Depends on: 909542
I've not yet started implementation. I am discussing it with my team members about API design. Current info I can share is the followings. APIs in Android - SCENE_MODE_HDR('hdr') : defined as a scene value - Camera.Parameters.setSceneMode('hdr') : set HDR - Camera.Parameters.getSceneMode() : if 'hdr' is already set, it returns 'hdr' - Camera.Parameters.getSupportedSceneModes() : if HDR is supported, the returned array includes 'hdr' If it's reasonable, we can add HDR feature as a scene mode using the existing Gecko APIs without any modifications. The below is the Gecko APIs mapped with the Android APIs. - 'hdr' : a scene value for HDR - nsDOMCameraControl::SetSceneMode('hdr') - nsDOMCameraControl::GetSceneMode() - DOMCameraCapabilities::GetSceneModes()
I agree with implementing SCENE_MODE_HDR. That is the simplest solution.
Assignee: mhabicher → hiro7998
Status: NEW → ASSIGNED
blocking-b2g: 1.4? → ---
Summary: [Camera][Gecko] Expose HDR settings → [Madai][Camera][Gecko] Expose HDR settings
HDR settings is not working on camera-dev-rebased. I tap on on/off and the option is not highlighted. I close and open the menu and the option I have selected is then highlighted. The indicator is not updated either
Flags: needinfo?(wilsonpage)
dmarcos: I don't think I have a device that supports HDR, so it doesn't show up in the settings menu. What device are you using? Does it have Gecko dependencies?
Flags: needinfo?(wilsonpage) → needinfo?(dmarcos)
Ah, I found the feature is apparent on the Nexus-4. Fixing the bug now.
Flags: needinfo?(dmarcos)
Please provide status on the gecko changes and overall HDR feature readiness for review? Thanks hema
Flags: needinfo?(jjoons79)
Youngwoo! Can you provide status?
Flags: needinfo?(jjoons79) → needinfo?(hiro7998)
I think it should be provided as a scene mode. Camera app in AOSP is implemented using the scene mode API for HDR. However the default camera library's implementations of AOSP do not seem to support the HDR feature. All they are mapping the HDR mode to another mode or the off-mode like the below. - QCOM : http://androidxref.com/4.4.2_r1/xref/hardware/qcom/camera/QCamera2/HAL/QCameraParameters.cpp#434 ==> SCENE_MODE_HDR map to CAM_SCENE_MODE_OFF - ASUS : http://androidxref.com/4.4.2_r1/xref/device/asus/flo/camera/QCamera2/HAL/QCameraParameters.cpp#434 ==> SCENE_MODE_HDR map to CAM_SCENE_MODE_OFF - LGE : http://androidxref.com/4.4.2_r1/xref/device/lge/mako/camera/QCameraHWI_Parm.cpp#222 ==> SCENE_MODE_HDR map to CAMERA_BESTSHOT_AUTO However, I think we'd better to implement this API using the format of scene mode. - API level : The scene mode API is already defined in AOSP and Gecko. - mode value : HDR mode is already defined in AOSP and Gecko can use the mode defined in AOSP. - Camera library : If the device-vendors want to implement HDR, they can modify or add the HDR implementation to their camera library to support it without any modification in the app-side and Gecko-side. And, even if HDR solution is vendor-specific and is not able to be provided as a scene mode, the way to implement it can be provided to the vendors with setParameter/getParameter APIs. (Bug 968644) As a result, I think that new HDR-related API is not needed.
Flags: needinfo?(hiro7998)
We have supported HDR mode for a while now.
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.