Closed
Bug 965498
Opened 11 years ago
Closed 11 years ago
Bluetooth leaks every blob
Categories
(Firefox OS Graveyard :: Bluetooth, defect)
Firefox OS Graveyard
Bluetooth
Tracking
(blocking-b2g:1.3+, firefox27 wontfix, firefox28 fixed, firefox29 fixed, b2g18 wontfix, b2g-v1.1hd wontfix, b2g-v1.2 wontfix, b2g-v1.3 fixed, b2g-v1.4 fixed)
People
(Reporter: khuey, Assigned: khuey)
References
Details
(Whiteboard: [MemShrink:P1])
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
khuey
:
review+
|
Details | Diff | Splinter Review |
aActor->GetBlob() returns already_AddRefed, which bluetooth is throwing away.
Attachment #8367558 -
Flags: review?(kyle)
|
||
Updated•11 years ago
|
Attachment #8367558 -
Flags: review?(kyle) → review+
|
Assignee | |
Comment 2•11 years ago
|
||
With reviewer information.
Assignee: nobody → khuey
Attachment #8367558 -
Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #8367566 -
Flags: review+
|
|
Assignee | |
Updated•11 years ago
|
|
||
Comment 3•11 years ago
|
||
Keywords: checkin-needed
|
||
Comment 4•11 years ago
|
||
Yikes. Did you find this via pure code inspection or did profiling data point you in this direction?
Flags: needinfo?(khuey)
|
||
Comment 5•11 years ago
|
||
bent noticed it while looking at a patch, I believe. There was some discussion at the DOM work week about eliminating this footgun (or at least making it more obvious than "get()"), but I'm not sure if a bug's been filed about it yet.
|
|
Assignee | |
Comment 6•11 years ago
|
||
Yeah, bent found it while looking at a patch that moved this code around. We came up with a plan for catching these sorts of errors at the work week today. More to come.
Also we really need to run b2g with leak checking turned on.
Flags: needinfo?(khuey)
|
||
Comment 7•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
|
|
||
Comment 8•11 years ago
|
||
status-b2g18:
--- → wontfix
status-b2g-v1.1hd:
--- → wontfix
status-b2g-v1.2:
--- → wontfix
status-b2g-v1.3:
--- → fixed
status-b2g-v1.4:
--- → fixed
status-firefox27:
--- → wontfix
status-firefox28:
--- → fixed
status-firefox29:
--- → fixed
Target Milestone: --- → 1.3 C3/1.4 S3(31jan)
|
|
||
Comment 9•11 years ago
|
||
Not sure if this is considered "stability" enough to be considered for v1.2 uplift still. You'll want to run it past RelMan if you think this should be uplifted there still.
|
|
Assignee | |
Updated•11 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•