Bhavna Sharma Reporter
	Description • 11 years ago

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/32.0.1700.76 Safari/537.36

Steps to reproduce:

setup a data by type i.e. nsIRadioInterface->setupdatacallbytype


Actual results:

The interface to setup the data call is very much tied to a radio interface.
Why should the upper layers be aware oh which sim (i.e. which radio interface) is being used to bring up a DataCall.

Requires a number of steps to be able to bring up the dataCall

// Find the DD sim first using ‘ril.data.defaultServiceId’
// Query on nsISettingsService

// Query for ril service
    nsCOMPtr<nsIRadioInterfaceLayer> ril;
    ril = do_GetService("@mozilla.org/ril;1");

// Query for radio interface
    nsCOMPtr<nsIRadioInterface> radioInterface;
    nsRes = ril->GetRadioInterface(mDedicatedDataSIM, getter_AddRefs(radioInterface));

// RegisterDatacallcallback
nsRes = mRadioInterface->RegisterDataCallCallback(this);

// bring up data call
mRadioInterface->SetupDataCallByType(NS_LITERAL_STRING("supl"));

In multisim scenario there should be a DataConnection manager which should abstract the radio interface details from the upper layers.


Expected results:

There should have been a DataConnectionManager that can abstract the radiointerface details from upper layers.

	Hsin-Yi Tsai (she/her) [:hsinyi]
	Comment 1 • 11 years ago

(In reply to Bhavna Sharma from comment #0)
> User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.36 (KHTML,
> like Gecko) Chrome/32.0.1700.76 Safari/537.36
> 
> Steps to reproduce:
> 
> setup a data by type i.e. nsIRadioInterface->setupdatacallbytype
> 
> 
> Actual results:
> 
> The interface to setup the data call is very much tied to a radio interface.
> Why should the upper layers be aware oh which sim (i.e. which radio
> interface) is being used to bring up a DataCall.
> 
> Requires a number of steps to be able to bring up the dataCall
> 
> // Find the DD sim first using ‘ril.data.defaultServiceId’
> // Query on nsISettingsService
> 
> // Query for ril service
>     nsCOMPtr<nsIRadioInterfaceLayer> ril;
>     ril = do_GetService("@mozilla.org/ril;1");
> 
> // Query for radio interface
>     nsCOMPtr<nsIRadioInterface> radioInterface;
>     nsRes = ril->GetRadioInterface(mDedicatedDataSIM,
> getter_AddRefs(radioInterface));
> 
> // RegisterDatacallcallback
> nsRes = mRadioInterface->RegisterDataCallCallback(this);
> 
> // bring up data call
> mRadioInterface->SetupDataCallByType(NS_LITERAL_STRING("supl"));
> 
> In multisim scenario there should be a DataConnection manager which should
> abstract the radio interface details from the upper layers.
> 
> 
> Expected results:
> 
> There should have been a DataConnectionManager that can abstract the
> radiointerface details from upper layers.

We've been planning this, see the meta bug 904514.

	Ken Chang[:kenkai]
	Comment 2 • 11 years ago

(In reply to Hsin-Yi Tsai  [:hsinyi] from comment #1)
> We've been planning this, see the meta bug 904514.
It's a big change. we don't need to be rush to finish it in 1.4.

	Preeti Raghunath(:Preeti)
	Comment 3 • 11 years ago

Hi Ken

This blocks QC CS in release 1.4. We need to fix it in 1.4 unless we believe its a heavy load to carry.

	Julien Wajsberg [:julienw]
	Comment 4 • 11 years ago

Why is it a blocker exactly?

	Bhavna Sharma Reporter
	Comment 5 • 11 years ago

hi Julien,

As of now we only support DSDS configurations, hence we can go without fixing this issue.
Once we have DSDA support it will become difficult for the clients to know which radio interface to use to bring up the DataCall.

I leave it you to decide on its priority, for v1.4 it is not a blocker.

- Bhavna

	Ken Chang[:kenkai]
	Comment 6 • 11 years ago

According to comment 5, we got the answer.

	Julien Wajsberg [:julienw]
	Comment 7 • 11 years ago

Bhavna: thanks for your detailed answer, be sure to bring this up again (and early enough ;) ) once we start working on DSDA !

	Ken Chang[:kenkai]
	Comment 8 • 11 years ago

Put this bug into backlog.

	Hsin-Yi Tsai (she/her) [:hsinyi]
	Comment 9 • 10 years ago

bug 904514 covers this. Close it as duplicate.